Read section headers upfront.
Instead of storing a pointer, store the members we need.
The reason for doing this is that it makes it far easier to create
synthetic sections. It also avoids reading data from files multiple
times., which might help with cross endian linking and host
architectures with slow unaligned access.
There are obvious compacting opportunities, but this already has mixed
results even on native x86_64 linking.
There is also the possibility of better refactoring the code for
handling common symbols, but this already shows that a custom class is
not necessary.
llvm-svn: 285148
diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp
index 5fd49eb..ed6dd69 100644
--- a/lld/ELF/LinkerScript.cpp
+++ b/lld/ELF/LinkerScript.cpp
@@ -184,7 +184,7 @@
if (!isDiscarded(S) && !S->OutSec && Pat.SectionRe.match(S->Name))
I->Sections.push_back(S);
if (Pat.SectionRe.match("COMMON"))
- I->Sections.push_back(CommonInputSection<ELFT>::X);
+ I->Sections.push_back(InputSection<ELFT>::CommonInputSection);
}
// Sort sections as instructed by SORT-family commands and --sort-section