[Inliner] Fold the analysis remark into the missed remark
There is really no reason for these to be separate.
The vectorizer started this pretty bad tradition that the text of the
missed remarks is pretty meaningless, i.e. vectorization failed. There,
you have to query analysis to get the full picture.
I think we should just explain the reason for missing the optimization
in the missed remark when possible. Analysis remarks should provide
information that the pass gathers regardless whether the optimization is
passing or not.
llvm-svn: 282542
diff --git a/llvm/test/Transforms/Inline/optimization-remarks-yaml.ll b/llvm/test/Transforms/Inline/optimization-remarks-yaml.ll
index 45ed78d..7afdd28 100644
--- a/llvm/test/Transforms/Inline/optimization-remarks-yaml.ll
+++ b/llvm/test/Transforms/Inline/optimization-remarks-yaml.ll
@@ -11,12 +11,12 @@
; 5 return foo() + bar();
; 6 }
-; CHECK: remark: /tmp/s.c:5:10: foo will not be inlined into baz (hotness: 30)
-; CHECK-NEXT: remark: /tmp/s.c:5:18: bar will not be inlined into baz (hotness: 30)
+; CHECK: remark: /tmp/s.c:5:10: foo will not be inlined into baz because its definition is unavailable (hotness: 30)
+; CHECK-NEXT: remark: /tmp/s.c:5:18: bar will not be inlined into baz because its definition is unavailable (hotness: 30)
; YAML: --- !Missed
; YAML-NEXT: Pass: inline
-; YAML-NEXT: Name: NotInlined
+; YAML-NEXT: Name: NoDefinition
; YAML-NEXT: DebugLoc: { File: /tmp/s.c, Line: 5, Column: 10 }
; YAML-NEXT: Function: baz
; YAML-NEXT: Hotness: 30
@@ -24,10 +24,11 @@
; YAML-NEXT: - Callee: foo
; YAML-NEXT: - String: will not be inlined into
; YAML-NEXT: - Caller: baz
+; YAML-NEXT: - String: because its definition is unavailable
; YAML-NEXT: ...
; YAML-NEXT: --- !Missed
; YAML-NEXT: Pass: inline
-; YAML-NEXT: Name: NotInlined
+; YAML-NEXT: Name: NoDefinition
; YAML-NEXT: DebugLoc: { File: /tmp/s.c, Line: 5, Column: 18 }
; YAML-NEXT: Function: baz
; YAML-NEXT: Hotness: 30
@@ -35,6 +36,7 @@
; YAML-NEXT: - Callee: bar
; YAML-NEXT: - String: will not be inlined into
; YAML-NEXT: - Caller: baz
+; YAML-NEXT: - String: because its definition is unavailable
; YAML-NEXT: ...
; ModuleID = '/tmp/s.c'