commit 117b1fa19af43aff5d4ef0e5f35b80c9c27c5cf1
author Zachary Turner <zturner@google.com> Thu Oct 25 20:45:40 2018 +0000
committer Zachary Turner <zturner@google.com> Thu Oct 25 20:45:40 2018 +0000
tree 94c2e53e2de6ed3fad41eb7c3cc40ba4eb5f6c1b
parent 991e44534a822a5c968ed85a0cce1cc529ad9e57

Don't type-erase the FunctionNameType or TypeClass enums.

This is similar to D53597, but following up with 2 more enums.
After this, all flag enums should be strongly typed all the way
through to the symbol files plugins.

Differential Revision: https://reviews.llvm.org/D53616

llvm-svn: 345314

lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp

diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
index 34440da..fdc9330 100644
--- a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
+++ b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
@@ -1148,7 +1148,7 @@
 
 uint32_t SymbolFileNativePDB::FindFunctions(
     const ConstString &name, const CompilerDeclContext *parent_decl_ctx,
-    uint32_t name_type_mask, bool include_inlines, bool append,
+    FunctionNameType name_type_mask, bool include_inlines, bool append,
     SymbolContextList &sc_list) {
   // For now we only support lookup by method name.
   if (!(name_type_mask & eFunctionNameTypeMethod))
@@ -1307,7 +1307,7 @@
 }
 
 size_t SymbolFileNativePDB::GetTypes(lldb_private::SymbolContextScope *sc_scope,
-                                     uint32_t type_mask,
+                                     TypeClass type_mask,
                                      lldb_private::TypeList &type_list) {
   return 0;
 }

lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h

diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
index 8b5e8cb..9a67740c 100644
--- a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
+++ b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
@@ -113,13 +113,14 @@
                                 lldb::SymbolContextItem resolve_scope,
                                 SymbolContext &sc) override;
 
-  size_t GetTypes(SymbolContextScope *sc_scope, uint32_t type_mask,
+  size_t GetTypes(SymbolContextScope *sc_scope, lldb::TypeClass type_mask,
                   TypeList &type_list) override;
 
   uint32_t FindFunctions(const ConstString &name,
                          const CompilerDeclContext *parent_decl_ctx,
-                         uint32_t name_type_mask, bool include_inlines,
-                         bool append, SymbolContextList &sc_list) override;
+                         lldb::FunctionNameType name_type_mask,
+                         bool include_inlines, bool append,
+                         SymbolContextList &sc_list) override;
 
   uint32_t FindFunctions(const RegularExpression &regex, bool include_inlines,
                          bool append, SymbolContextList &sc_list) override;