commit 149f6eaed9818057b83d8f0b17bb5e8764a13143
author Mehdi Amini <mehdi.amini@apple.com> Wed Oct 05 05:59:29 2016 +0000
committer Mehdi Amini <mehdi.amini@apple.com> Wed Oct 05 05:59:29 2016 +0000
tree b0b1a0063de2bc0dfc3db17266a1d477be54c844
parent efe40389c0e82cf173f88979c56420dfeba6b8ed

Re-commit "Use StringRef in Support/Darf APIs (NFC)"

This reverts commit r283285 and re-commit r283275 with
a fix for format("%s", Str); where Str is a StringRef.

llvm-svn: 283298

llvm/lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp

diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp
index 62d5e66..c43456b 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugInfoEntry.cpp
@@ -45,12 +45,12 @@
 
     if (abbrCode) {
       if (AbbrevDecl) {
-          const char *tagString = TagString(getTag());
-          if (tagString)
-            WithColor(OS, syntax::Tag).get().indent(indent) << tagString;
-          else
-            WithColor(OS, syntax::Tag).get().indent(indent) <<
-              format("DW_TAG_Unknown_%x", getTag());
+        auto tagString = TagString(getTag());
+        if (!tagString.empty())
+          WithColor(OS, syntax::Tag).get().indent(indent) << tagString;
+        else
+          WithColor(OS, syntax::Tag).get().indent(indent)
+              << format("DW_TAG_Unknown_%x", getTag());
 
         OS << format(" [%u] %c\n", abbrCode,
                      AbbrevDecl->hasChildren() ? '*' : ' ');
@@ -83,7 +83,8 @@
     uint64_t Shift = countTrailingZeros(Val);
     assert(Shift < 64 && "undefined behavior");
     uint64_t Bit = 1ULL << Shift;
-    if (const char *PropName = ApplePropertyString(Bit))
+    auto PropName = ApplePropertyString(Bit);
+    if (!PropName.empty())
       OS << PropName;
     else
       OS << format("DW_APPLE_PROPERTY_0x%" PRIx64, Bit);
@@ -116,14 +117,14 @@
   const char BaseIndent[] = "            ";
   OS << BaseIndent;
   OS.indent(indent+2);
-  const char *attrString = AttributeString(attr);
-  if (attrString)
+  auto attrString = AttributeString(attr);
+  if (!attrString.empty())
     WithColor(OS, syntax::Attribute) << attrString;
   else
     WithColor(OS, syntax::Attribute).get() << format("DW_AT_Unknown_%x", attr);
 
-  const char *formString = FormEncodingString(form);
-  if (formString)
+  auto formString = FormEncodingString(form);
+  if (!formString.empty())
     OS << " [" << formString << ']';
   else
     OS << format(" [DW_FORM_Unknown_%x]", form);
@@ -134,8 +135,8 @@
     return;
 
   OS << "\t(";
-  
-  const char *Name = nullptr;
+
+  StringRef Name;
   std::string File;
   auto Color = syntax::Enumerator;
   if (attr == DW_AT_decl_file || attr == DW_AT_call_file) {
@@ -146,12 +147,12 @@
              u->getCompilationDir(),
              DILineInfoSpecifier::FileLineInfoKind::AbsoluteFilePath, File)) {
         File = '"' + File + '"';
-        Name = File.c_str();
+        Name = File;
       }
   } else if (Optional<uint64_t> Val = formValue.getAsUnsignedConstant())
     Name = AttributeValueString(attr, *Val);
 
-  if (Name)
+  if (!Name.empty())
     WithColor(OS, Color) << Name;
   else if (attr == DW_AT_decl_line || attr == DW_AT_call_line)
     OS << *formValue.getAsUnsignedConstant();