Change the diagnostics interface to take an array of pointers to
strings instead of array of strings. This reduces string copying
in some not-very-important cases, but paves the way for future
improvements.
llvm-svn: 59494
diff --git a/clang/lib/Parse/DeclSpec.cpp b/clang/lib/Parse/DeclSpec.cpp
index e800761..733c37c 100644
--- a/clang/lib/Parse/DeclSpec.cpp
+++ b/clang/lib/Parse/DeclSpec.cpp
@@ -311,6 +311,7 @@
}
void DeclSpec::Diag(Diagnostic &D, SourceLocation Loc, SourceManager& SrcMgr,
- unsigned DiagID, const std::string &info) {
- D.Report(FullSourceLoc(Loc,SrcMgr), DiagID, &info, 1);
+ unsigned DiagID, const std::string &Info) {
+ const std::string *Strs[] = { &Info };
+ D.Report(FullSourceLoc(Loc,SrcMgr), DiagID, Strs, 1);
}
diff --git a/clang/lib/Parse/Parser.cpp b/clang/lib/Parse/Parser.cpp
index 3b36ebe..dfabc9b 100644
--- a/clang/lib/Parse/Parser.cpp
+++ b/clang/lib/Parse/Parser.cpp
@@ -43,13 +43,15 @@
bool Parser::Diag(SourceLocation Loc, unsigned DiagID,
const std::string &Msg) {
- Diags.Report(FullSourceLoc(Loc,PP.getSourceManager()), DiagID, &Msg, 1);
+ const std::string *Strs[] = { &Msg };
+ Diags.Report(FullSourceLoc(Loc,PP.getSourceManager()), DiagID, Strs, 1);
return true;
}
bool Parser::Diag(SourceLocation Loc, unsigned DiagID, const std::string &Msg,
const SourceRange& Range) {
- Diags.Report(PP.getFullLoc(Loc), DiagID, &Msg, 1, &Range,1);
+ const std::string *Strs[] = { &Msg };
+ Diags.Report(PP.getFullLoc(Loc), DiagID, Strs, 1, &Range,1);
return true;
}