commit 1a65ae11bd65d007391473f8bde3d06f4abad740
author Greg Clayton <gclayton@apple.com> Tue Jan 25 23:55:37 2011 +0000
committer Greg Clayton <gclayton@apple.com> Tue Jan 25 23:55:37 2011 +0000
tree 12bcbcdd2564d2bf305c3642ebe3a0b80128beb7
parent 3ae681eb1240f09af37936663760526ed1b324cf

Enabled extra warnings and fixed a bunch of small issues.

llvm-svn: 124250

lldb/source/Core/DataExtractor.cpp

diff --git a/lldb/source/Core/DataExtractor.cpp b/lldb/source/Core/DataExtractor.cpp
index e6c8a4d..2c80541 100644
--- a/lldb/source/Core/DataExtractor.cpp
+++ b/lldb/source/Core/DataExtractor.cpp
@@ -1253,7 +1253,7 @@
                 // earlier C++ libraries
                 std::string binary_value(64, '0');
                 std::bitset<64> bits(uval64);
-                for (size_t i = 0; i < 64; ++i)
+                for (i = 0; i < 64; ++i)
                     if (bits[i])
                         binary_value[64 - 1 - i] = '1';
                 if (item_bit_size > 0)

lldb/source/Core/Value.cpp

diff --git a/lldb/source/Core/Value.cpp b/lldb/source/Core/Value.cpp
index ce6a95b..41483c7 100644
--- a/lldb/source/Core/Value.cpp
+++ b/lldb/source/Core/Value.cpp
@@ -142,6 +142,26 @@
     }
 }
 
+Value &
+Value::operator=(const Value &rhs)
+{
+    if (this != &rhs)
+    {
+        m_value = rhs.m_value;
+        m_value_type = rhs.m_value_type;
+        m_context = rhs.m_context;
+        m_context_type = rhs.m_context_type;
+        if ((uintptr_t)rhs.m_value.ULongLong(LLDB_INVALID_ADDRESS) == (uintptr_t)rhs.m_data_buffer.GetBytes())
+        {
+            m_data_buffer.CopyData(rhs.m_data_buffer.GetBytes(),
+                                   rhs.m_data_buffer.GetByteSize());
+        
+            m_value = (uintptr_t)m_data_buffer.GetBytes();
+        }
+    }
+    return *this;
+}
+
 Value *
 Value::CreateProxy()
 {
@@ -653,17 +673,17 @@
     {
         // Resolve the proxy
         
-        Value * v = (Value*)m_context;
+        Value * rhs = (Value*)m_context;
         
-        m_value = v->m_value;
-        m_value_type = v->m_value_type;
-        m_context = v->m_context;
-        m_context_type = v->m_context_type;
+        m_value = rhs->m_value;
+        m_value_type = rhs->m_value_type;
+        m_context = rhs->m_context;
+        m_context_type = rhs->m_context_type;
         
-        if ((uintptr_t)v->m_value.ULongLong(LLDB_INVALID_ADDRESS) == (uintptr_t)v->m_data_buffer.GetBytes())
+        if ((uintptr_t)rhs->m_value.ULongLong(LLDB_INVALID_ADDRESS) == (uintptr_t)rhs->m_data_buffer.GetBytes())
         {
-            m_data_buffer.CopyData(v->m_data_buffer.GetBytes(),
-                                   v->m_data_buffer.GetByteSize());
+            m_data_buffer.CopyData(rhs->m_data_buffer.GetBytes(),
+                                   rhs->m_data_buffer.GetByteSize());
             
             m_value = (uintptr_t)m_data_buffer.GetBytes();
         }

lldb/source/Core/ValueObjectVariable.cpp

diff --git a/lldb/source/Core/ValueObjectVariable.cpp b/lldb/source/Core/ValueObjectVariable.cpp
index bcf4206..f73ce64 100644
--- a/lldb/source/Core/ValueObjectVariable.cpp
+++ b/lldb/source/Core/ValueObjectVariable.cpp
@@ -118,7 +118,7 @@
             loclist_base_load_addr = sc.function->GetAddressRange().GetBaseAddress().GetLoadAddress (exe_ctx.target);
     }
     Value old_value(m_value);
-    if (expr.Evaluate (&exe_ctx, GetClangAST(), NULL, loclist_base_load_addr, NULL, m_value, &m_error))
+    if (expr.Evaluate (&exe_ctx, GetClangAST(), NULL, NULL, NULL, loclist_base_load_addr, NULL, m_value, &m_error))
     {
         m_value.SetContext(Value::eContextTypeVariable, variable);