commit 1b7f49c2d6072f3e1432877a5e78ca946845bd2c
author Ted Kremenek <kremenek@apple.com> Thu Aug 25 19:28:55 2011 +0000
committer Ted Kremenek <kremenek@apple.com> Thu Aug 25 19:28:55 2011 +0000
tree 544f48e8c257e1c82f275ad20807f18d109fc571
parent 5e30972cfff2a49cb0d5952a74cc10c10b996112

Teach -Wunreachable-code about dead code caused by macro expansions.  This should suppress false positives resulting from 'assert' and friends.

llvm-svn: 138576

clang/lib/Analysis/ReachableCode.cpp

diff --git a/clang/lib/Analysis/ReachableCode.cpp b/clang/lib/Analysis/ReachableCode.cpp
index e3194cb..4931771 100644
--- a/clang/lib/Analysis/ReachableCode.cpp
+++ b/clang/lib/Analysis/ReachableCode.cpp
@@ -86,12 +86,10 @@
 }
 
 static bool isValidDeadStmt(const Stmt *S) {
-  SourceLocation Loc = S->getLocStart();
-  if (!(Loc.isValid() && !Loc.isMacroID()))
+  if (S->getLocStart().isInvalid())
     return false;
-  if (const BinaryOperator *BO = dyn_cast<BinaryOperator>(S)) {
+  if (const BinaryOperator *BO = dyn_cast<BinaryOperator>(S))
     return BO->getOpcode() != BO_Comma;
-  }
   return true;
 }
 
@@ -144,6 +142,12 @@
       }
       continue;
     }
+    
+    // Specially handle macro-expanded code.
+    if (S->getLocStart().isMacroID()) {
+      count += clang::reachable_code::ScanReachableFromBlock(Block, Reachable);
+      continue;
+    }
 
     if (isDeadCodeRoot(Block)) {
       reportDeadCode(S, CB);