commit 1cd399c915a746b0426a8a094906fb5f2a6cea12
author Simon Pilgrim <llvm-dev@redking.me.uk> Thu Oct 03 11:22:48 2019 +0000
committer Simon Pilgrim <llvm-dev@redking.me.uk> Thu Oct 03 11:22:48 2019 +0000
tree 2519659e9f589d3ac6bf1914046d2e7d689e1f43
parent 44bc1186e4bdb54f7f15dea8e85d9e83827bd0d0

Silence static analyzer getAs<RecordType> null dereference warnings. NFCI.

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<RecordType> directly and if not assert will fire for us.

llvm-svn: 373584

clang/lib/CodeGen/CGDecl.cpp

diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
index 5c0d52a..e40e968 100644
--- a/clang/lib/CodeGen/CGDecl.cpp
+++ b/clang/lib/CodeGen/CGDecl.cpp
@@ -2395,7 +2395,7 @@
     // Don't push a cleanup in a thunk for a method that will also emit a
     // cleanup.
     if (hasAggregateEvaluationKind(Ty) && !CurFuncIsThunk &&
-        Ty->getAs<RecordType>()->getDecl()->isParamDestroyedInCallee()) {
+        Ty->castAs<RecordType>()->getDecl()->isParamDestroyedInCallee()) {
       if (QualType::DestructionKind DtorKind =
               D.needsDestruction(getContext())) {
         assert((DtorKind == QualType::DK_cxx_destructor ||