commit 1cd399c915a746b0426a8a094906fb5f2a6cea12
author Simon Pilgrim <llvm-dev@redking.me.uk> Thu Oct 03 11:22:48 2019 +0000
committer Simon Pilgrim <llvm-dev@redking.me.uk> Thu Oct 03 11:22:48 2019 +0000
tree 2519659e9f589d3ac6bf1914046d2e7d689e1f43
parent 44bc1186e4bdb54f7f15dea8e85d9e83827bd0d0

Silence static analyzer getAs<RecordType> null dereference warnings. NFCI.

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<RecordType> directly and if not assert will fire for us.

llvm-svn: 373584

clang/lib/Sema/SemaAccess.cpp

diff --git a/clang/lib/Sema/SemaAccess.cpp b/clang/lib/Sema/SemaAccess.cpp
index b6fbbbf..b20f279 100644
--- a/clang/lib/Sema/SemaAccess.cpp
+++ b/clang/lib/Sema/SemaAccess.cpp
@@ -1834,8 +1834,8 @@
     return AR_accessible;
 
   CXXRecordDecl *BaseD, *DerivedD;
-  BaseD = cast<CXXRecordDecl>(Base->getAs<RecordType>()->getDecl());
-  DerivedD = cast<CXXRecordDecl>(Derived->getAs<RecordType>()->getDecl());
+  BaseD = cast<CXXRecordDecl>(Base->castAs<RecordType>()->getDecl());
+  DerivedD = cast<CXXRecordDecl>(Derived->castAs<RecordType>()->getDecl());
 
   AccessTarget Entity(Context, AccessTarget::Base, BaseD, DerivedD,
                       Path.Access);