commit 1d12ab3db192bf28e5fe2df01919fdba2a09826b
author Rafael Espindola <rafael.espindola@gmail.com> Fri Sep 11 21:44:55 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Fri Sep 11 21:44:55 2015 +0000
tree e7887f4922f61c8b00d4b6732be07bfe6913570a
parent 9d08009dffe0ca288451e9c862da835a25fba46a

Fix handling of _start being undefined.

We were crashing before.

llvm-svn: 247481

lld/ELF/Writer.cpp

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index 85b6016..ef7199c 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -476,8 +476,6 @@
       Out = &W.getBSS();
       break;
     case SymbolBody::UndefinedKind:
-      if (!Body->isWeak())
-        error(Twine("undefined symbol: ") + Name);
     case SymbolBody::DefinedAbsoluteKind:
     case SymbolBody::SharedKind:
       break;
@@ -614,6 +612,9 @@
   for (auto &P : Symtab.getSymbols()) {
     StringRef Name = P.first;
     SymbolBody *Body = P.second->Body;
+    if (Body->isStrongUndefined())
+      error(Twine("undefined symbol: ") + Name);
+
     if (auto *C = dyn_cast<DefinedCommon<ELFT>>(Body))
       CommonSymbols.push_back(C);
     if (!includeInSymtab(*Body))