commit 20122a436c31f61a0063f10759589ec0c73bac31
author Rafael Espindola <rafael.espindola@gmail.com> Fri Jan 31 20:57:12 2014 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Fri Jan 31 20:57:12 2014 +0000
tree d406560fbb040d1553cbe5139f6a4b58ae2fd936
parent 67294e253edd8cc39a6c66100b777a034d46761d

Simplify getSymbolFlags.

None of the object formats require extra parsing to compute these flags,
so the method cannot fail.

llvm-svn: 200574

llvm/lib/Object/COFFObjectFile.cpp

diff --git a/llvm/lib/Object/COFFObjectFile.cpp b/llvm/lib/Object/COFFObjectFile.cpp
index 43321c4..78cf1ab6 100644
--- a/llvm/lib/Object/COFFObjectFile.cpp
+++ b/llvm/lib/Object/COFFObjectFile.cpp
@@ -155,10 +155,9 @@
   return object_error::success;
 }
 
-error_code COFFObjectFile::getSymbolFlags(DataRefImpl Ref,
-                                          uint32_t &Result) const {
+uint32_t COFFObjectFile::getSymbolFlags(DataRefImpl Ref) const {
   const coff_symbol *Symb = toSymb(Ref);
-  Result = SymbolRef::SF_None;
+  uint32_t Result = SymbolRef::SF_None;
 
   // TODO: Correctly set SF_FormatSpecific, SF_ThreadLocal, SF_Common
 
@@ -176,7 +175,7 @@
   if (Symb->SectionNumber == COFF::IMAGE_SYM_ABSOLUTE)
     Result |= SymbolRef::SF_Absolute;
 
-  return object_error::success;
+  return Result;
 }
 
 error_code COFFObjectFile::getSymbolSize(DataRefImpl Ref,