commit 204efe2de83bc5dd2fae89c272d562560e4568bd
author Xinliang David Li <davidxl@google.com> Mon Jan 04 22:09:26 2016 +0000
committer Xinliang David Li <davidxl@google.com> Mon Jan 04 22:09:26 2016 +0000
tree 6190f5038385aa35c6c6db3597e3e350587c51d9
parent 120fe2e8981c8cede9e5ec60bd0411fb8c1eac35

[PGO] Simplify string parsing

Patch Suggested by Vedant.

llvm-svn: 256785

llvm/lib/ProfileData/InstrProf.cpp

diff --git a/llvm/lib/ProfileData/InstrProf.cpp b/llvm/lib/ProfileData/InstrProf.cpp
index bcb248e..027f0f7 100644
--- a/llvm/lib/ProfileData/InstrProf.cpp
+++ b/llvm/lib/ProfileData/InstrProf.cpp
@@ -245,20 +245,10 @@
       P += UncompressedSize;
     }
     // Now parse the name strings.
-    size_t NameStart = 0;
-    bool isLast = false;
-    do {
-      size_t NameStop = NameStrings.find(' ', NameStart);
-      if (NameStop == StringRef::npos)
-        NameStop = NameStrings.size();
-      if (NameStop >= NameStrings.size() - 1)
-        isLast = true;
-      StringRef Name = NameStrings.substr(NameStart, NameStop - NameStart);
+    SmallVector<StringRef, 0> Names;
+    NameStrings.split(Names, ' ');
+    for (StringRef &Name : Names)
       Symtab.addFuncName(Name);
-      if (isLast)
-        break;
-      NameStart = NameStop + 1;
-    } while (true);
 
     while (P < EndP && *P == 0)
       P++;