Only warn about missing/incomplete -dealloc implementations when a class contains a non-SEL, non-IBOutlet ivar that references an ObjC object.
llvm-svn: 54024
diff --git a/clang/lib/Analysis/CheckObjCDealloc.cpp b/clang/lib/Analysis/CheckObjCDealloc.cpp
index a67f84a..ba0eb6a 100644
--- a/clang/lib/Analysis/CheckObjCDealloc.cpp
+++ b/clang/lib/Analysis/CheckObjCDealloc.cpp
@@ -71,12 +71,13 @@
ObjCIvarDecl* ID = *I;
QualType T = ID->getType();
- if ((T->isPointerType() || Ctx.isObjCObjectPointerType(T)) &&
- (ID->getAttr<IBOutletAttr>() == 0 && // Skip IBOutlets.
- !isSEL(T, SelII))) { // Skip SEL ivars.
- containsPointerIvar = true;
- break;
- }
+ if (!Ctx.isObjCObjectPointerType(T) ||
+ ID->getAttr<IBOutletAttr>() || // Skip IBOutlets.
+ isSEL(T, SelII)) // Skip SEL ivars.
+ continue;
+
+ containsPointerIvar = true;
+ break;
}
if (!containsPointerIvar)