commit 24937c12ebbc4d1128618d0f0ff7b1e638a5471d
author Tim Northover <Tim.Northover@arm.com> Mon Feb 04 15:44:38 2013 +0000
committer Tim Northover <Tim.Northover@arm.com> Mon Feb 04 15:44:38 2013 +0000
tree da74efe1f3fd69739b0606bc61c1d495e75e02d5
parent 2c9da989c20aacc523b8751ca45a11f4f24f8d54

Fix some abuses of StringRef

We were taking a StringRef to a temporary result, which can go horribly wrong.

llvm-svn: 174328

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

diff --git a/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp b/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
index 34026344..49bec59 100644
--- a/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
+++ b/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
@@ -1207,8 +1207,8 @@
     return MatchOperand_ParseFail;
   }
 
-  StringRef lowerCase = Parser.getTok().getIdentifier().lower();
-  RefKind = StringSwitch<AArch64MCExpr::VariantKind>(lowerCase)
+  std::string LowerCase = Parser.getTok().getIdentifier().lower();
+  RefKind = StringSwitch<AArch64MCExpr::VariantKind>(LowerCase)
     .Case("got",              AArch64MCExpr::VK_AARCH64_GOT)
     .Case("got_lo12",         AArch64MCExpr::VK_AARCH64_GOT_LO12)
     .Case("lo12",             AArch64MCExpr::VK_AARCH64_LO12)
@@ -1343,7 +1343,8 @@
     return MatchOperand_ParseFail;
   }
 
-  StringRef Tok = Parser.getTok().getIdentifier().lower();
+  std::string LowerTok = Parser.getTok().getIdentifier().lower();
+  StringRef Tok(LowerTok);
   if (Tok[0] != 'c') {
     Error(S, "Expected cN operand where 0 <= N <= 15");
     return MatchOperand_ParseFail;