When making a clone of a DSGraph from the BU pass, make sure to remember that
this clone is supposed to be used for *ALL* of the functions in the SCC.
This fixes the memory explosion problem the TD pass was having, reducing the
memory growth from 24MB -> 3.5MB on povray and 270MB ->8.3MB on perlbmk!
This obviously also speeds up the TD pass *a lot*.
llvm-svn: 20763
diff --git a/llvm/lib/Analysis/DataStructure/TopDownClosure.cpp b/llvm/lib/Analysis/DataStructure/TopDownClosure.cpp
index f1aea79..45b2f2b 100644
--- a/llvm/lib/Analysis/DataStructure/TopDownClosure.cpp
+++ b/llvm/lib/Analysis/DataStructure/TopDownClosure.cpp
@@ -105,8 +105,8 @@
for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I)
if (!I->isExternal())
getOrCreateDSGraph(*I);
+ return false;
}
-//return false;
#endif
@@ -154,6 +154,13 @@
assert(G->getAuxFunctionCalls().empty() && "Cloned aux calls?");
G->setPrintAuxCalls();
G->setGlobalsGraph(GlobalsGraph);
+
+ // Note that this graph is the graph for ALL of the function in the SCC, not
+ // just F.
+ for (DSGraph::retnodes_iterator RI = G->retnodes_begin(),
+ E = G->retnodes_end(); RI != E; ++RI)
+ if (RI->first != &F)
+ DSInfo[RI->first] = G;
}
return *G;
}