commit 2602a683e09c84ec4e28314abb60c6e2a900ef0e
author Richard Smith <richard-llvm@metafoo.co.uk> Tue Jun 21 23:42:09 2011 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Tue Jun 21 23:42:09 2011 +0000
tree 785be00529f1278236e6d3eb08d0d07201d4f9c0
parent cf5f43ce1fdd4bbade729dc478ea77efc6d807b5

Fix PR10168: don't warn for unused non-dependent variables in both the template definition and each instantiation.

llvm-svn: 133580

clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

diff --git a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
index e78aa29..cc66ec6 100644
--- a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
@@ -415,8 +415,10 @@
              !Var->isCXXForRangeDecl())
     SemaRef.ActOnUninitializedDecl(Var, false);
 
-  // Diagnose unused local variables.
-  if (!Var->isInvalidDecl() && Owner->isFunctionOrMethod() && !Var->isUsed())
+  // Diagnose unused local variables with dependent types, where the diagnostic
+  // will have been deferred.
+  if (!Var->isInvalidDecl() && Owner->isFunctionOrMethod() && !Var->isUsed() &&
+      D->getType()->isDependentType())
     SemaRef.DiagnoseUnusedDecl(Var);
 
   return Var;