Refactor duplicated code. NFC.
llvm-svn: 281329
diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp
index bbe4943..b7f7194 100644
--- a/lld/ELF/LinkerScript.cpp
+++ b/lld/ELF/LinkerScript.cpp
@@ -216,6 +216,15 @@
template <class ELFT>
void LinkerScript<ELFT>::createSections(OutputSectionFactory<ELFT> &Factory) {
+ auto AddSec = [&](InputSectionBase<ELFT> *Sec, StringRef Name) {
+ OutputSectionBase<ELFT> *OutSec;
+ bool IsNew;
+ std::tie(OutSec, IsNew) = Factory.create(Sec, Name);
+ if (IsNew)
+ OutputSections->push_back(OutSec);
+ return OutSec;
+ };
+
for (const std::unique_ptr<BaseCommand> &Base1 : Opt.Commands) {
if (auto *Cmd = dyn_cast<SymbolAssignment>(Base1.get())) {
if (shouldDefine<ELFT>(Cmd))
@@ -235,12 +244,7 @@
continue;
for (InputSectionBase<ELFT> *Sec : V) {
- OutputSectionBase<ELFT> *OutSec;
- bool IsNew;
- std::tie(OutSec, IsNew) = Factory.create(Sec, Cmd->Name);
- if (IsNew)
- OutputSections->push_back(OutSec);
-
+ OutputSectionBase<ELFT> *OutSec = AddSec(Sec, Cmd->Name);
uint32_t Subalign = Cmd->SubalignExpr ? Cmd->SubalignExpr(0) : 0;
if (Subalign)
@@ -256,11 +260,7 @@
for (InputSectionBase<ELFT> *S : F->getSections()) {
if (isDiscarded(S) || S->OutSec)
continue;
- OutputSectionBase<ELFT> *OutSec;
- bool IsNew;
- std::tie(OutSec, IsNew) = Factory.create(S, getOutputSectionName(S));
- if (IsNew)
- OutputSections->push_back(OutSec);
+ OutputSectionBase<ELFT> *OutSec = AddSec(S, getOutputSectionName(S));
OutSec->addSection(S);
}
}