commit 2ad19016c086d1915a8e96e2a63ca291719300ee
author Nicolai Haehnle <nhaehnle@gmail.com> Mon Mar 19 14:14:28 2018 +0000
committer Nicolai Haehnle <nhaehnle@gmail.com> Mon Mar 19 14:14:28 2018 +0000
tree d448ca5aecd87d6033555c8656b27754736509e0
parent 4186cc7c08b2c1cdd7f7a583fa728e065b5be033

TableGen: Explicitly forbid self-references to field members

Summary:
Otherwise, patterns like in the test case produce cryptic error
messages about fields being resolved incompletely.

Change-Id: I713c0191f00fe140ad698675803ab1f8823dc5bd

Reviewers: arsenm, craig.topper, tra, MartinO

Subscribers: wdng, llvm-commits

Differential Revision: https://reviews.llvm.org/D44476

llvm-svn: 327850

llvm/include/llvm/TableGen/Record.h

diff --git a/llvm/include/llvm/TableGen/Record.h b/llvm/include/llvm/TableGen/Record.h
index 9aaf121..8ba1992 100644
--- a/llvm/include/llvm/TableGen/Record.h
+++ b/llvm/include/llvm/TableGen/Record.h
@@ -1200,7 +1200,7 @@
   Init *getBit(unsigned Bit) const override;
 
   Init *resolveReferences(Resolver &R) const override;
-  Init *Fold() const;
+  Init *Fold(Record *CurRec) const;
 
   std::string getAsString() const override {
     return Rec->getAsString() + "." + FieldName->getValue().str();

llvm/lib/TableGen/Record.cpp

diff --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp
index 333f45b..866cda3 100644
--- a/llvm/lib/TableGen/Record.cpp
+++ b/llvm/lib/TableGen/Record.cpp
@@ -1684,13 +1684,19 @@
 Init *FieldInit::resolveReferences(Resolver &R) const {
   Init *NewRec = Rec->resolveReferences(R);
   if (NewRec != Rec)
-    return FieldInit::get(NewRec, FieldName)->Fold();
+    return FieldInit::get(NewRec, FieldName)->Fold(R.getCurrentRecord());
   return const_cast<FieldInit *>(this);
 }
 
-Init *FieldInit::Fold() const {
+Init *FieldInit::Fold(Record *CurRec) const {
   if (DefInit *DI = dyn_cast<DefInit>(Rec)) {
-    Init *FieldVal = DI->getDef()->getValue(FieldName)->getValue();
+    Record *Def = DI->getDef();
+    if (Def == CurRec)
+      PrintFatalError(CurRec->getLoc(),
+                      Twine("Attempting to access field '") +
+                      FieldName->getAsUnquotedString() + "' of '" +
+                      Rec->getAsString() + "' is a forbidden self-reference");
+    Init *FieldVal = Def->getValue(FieldName)->getValue();
     if (FieldVal->isComplete())
       return FieldVal;
   }

llvm/lib/TableGen/TGParser.cpp

diff --git a/llvm/lib/TableGen/TGParser.cpp b/llvm/lib/TableGen/TGParser.cpp
index 0c92cf7..0eb7542 100644
--- a/llvm/lib/TableGen/TGParser.cpp
+++ b/llvm/lib/TableGen/TGParser.cpp
@@ -1943,7 +1943,7 @@
                  Result->getAsString() + "'");
         return nullptr;
       }
-      Result = FieldInit::get(Result, FieldName)->Fold();
+      Result = FieldInit::get(Result, FieldName)->Fold(CurRec);
       Lex.Lex();  // eat field name
       break;
     }

llvm/test/TableGen/self-reference-recursion.td

diff --git a/llvm/test/TableGen/self-reference-recursion.td b/llvm/test/TableGen/self-reference-recursion.td
new file mode 100644
index 0000000..7eadfb7
--- /dev/null
+++ b/llvm/test/TableGen/self-reference-recursion.td
@@ -0,0 +1,9 @@
+// RUN: not llvm-tblgen %s 2>&1 | FileCheck %s
+// XFAIL: vg_leak
+
+class A<string self> {
+  int x = !cast<A>(self).x;
+}
+
+// CHECK: error: Attempting to access field 'x' of 'A0' is a forbidden self-reference
+def A0 : A<"A0">;