commit 2df36481b6e20664b6a0206165e71cffda0569ba
author Angel Garcia Gomez <angelgarcia@google.com> Wed Oct 14 09:29:55 2015 +0000
committer Angel Garcia Gomez <angelgarcia@google.com> Wed Oct 14 09:29:55 2015 +0000
tree 504a9c8e45230b7e63bdd904e19dd785107537eb
parent baf573eb4cecd5f3a8ebc55210fbf45de2ff7c78

Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

Summary: This fixes https://llvm.org/bugs/show_bug.cgi?id=25082 .

Reviewers: bkramer, klimek

Subscribers: cfe-commits, alexfh

Differential Revision: http://reviews.llvm.org/D13504

llvm-svn: 250284

clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp

diff --git a/clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp
index a940547..1469909 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp
@@ -222,6 +222,9 @@
              has(varDecl()),
              unless(has(varDecl(anyOf(
                  unless(hasInitializer(ignoringParenImpCasts(cxxNewExpr()))),
+                 // Skip declarations that are already using auto.
+                 anyOf(hasType(autoType()),
+                       hasType(pointerType(pointee(autoType())))),
                  // FIXME: TypeLoc information is not reliable where CV
                  // qualifiers are concerned so these types can't be
                  // handled for now.