commit 3126c6c565efed0d3d5391b5fc35f841759ff876
author Rui Ueyama <ruiu@google.com> Sat Jul 04 02:00:22 2015 +0000
committer Rui Ueyama <ruiu@google.com> Sat Jul 04 02:00:22 2015 +0000
tree 3f89632b0f2a855d81099957ce7a008c3ebd9471
parent a3d463df6fb6896135eb29e6c39a7c9bebc64c8d

Use map::insert instead of checking existence of a key and insert. NFC.

llvm-svn: 241385

lld/COFF/DriverUtils.cpp

diff --git a/lld/COFF/DriverUtils.cpp b/lld/COFF/DriverUtils.cpp
index 451dcd4..2cd3684 100644
--- a/lld/COFF/DriverUtils.cpp
+++ b/lld/COFF/DriverUtils.cpp
@@ -399,13 +399,14 @@
   std::map<StringRef, Export *> Map;
   std::vector<Export> V;
   for (Export &E : Config->Exports) {
-    auto It = Map.find(E.Name);
-    if (It == Map.end()) {
-      Map.insert(It, std::make_pair(E.Name, &E));
+    auto Pair = Map.insert(std::make_pair(E.Name, &E));
+    bool Inserted = Pair.second;
+    if (Inserted) {
       V.push_back(E);
       continue;
     }
-    if (E == *It->second)
+    Export *Existing = Pair.first->second;
+    if (E == *Existing)
       continue;
     llvm::errs() << "warning: duplicate /export option: " << E.Name << "\n";
     continue;