Verifier: Function metadata attachments require a body
Add a verifier check that only functions with bodies have metadata
attachments. This should help catch bugs in frontends and
transformation passes. Part of PR23340.
llvm-svn: 235784
diff --git a/llvm/unittests/IR/MetadataTest.cpp b/llvm/unittests/IR/MetadataTest.cpp
index 3368221..cb882e7 100644
--- a/llvm/unittests/IR/MetadataTest.cpp
+++ b/llvm/unittests/IR/MetadataTest.cpp
@@ -17,6 +17,7 @@
#include "llvm/IR/Metadata.h"
#include "llvm/IR/Module.h"
#include "llvm/IR/Type.h"
+#include "llvm/IR/Verifier.h"
#include "llvm/Support/raw_ostream.h"
#include "gtest/gtest.h"
using namespace llvm;
@@ -2233,4 +2234,21 @@
EXPECT_FALSE(F->hasMetadata());
}
+TEST_F(FunctionAttachmentTest, Verifier) {
+ Function *F = getFunction("foo");
+ F->setMetadata("attach", getTuple());
+
+ // Confirm this has no body.
+ ASSERT_TRUE(F->empty());
+
+ // Functions without a body cannot have metadata attachments (they also can't
+ // be verified directly, so check that the module fails to verify).
+ EXPECT_TRUE(verifyModule(*F->getParent()));
+
+ // Functions with a body can.
+ (void)new UnreachableInst(Context, BasicBlock::Create(Context, "bb", F));
+ EXPECT_FALSE(verifyModule(*F->getParent()));
+ EXPECT_FALSE(verifyFunction(*F));
+}
+
}