commit 35303fd739705b9167fb2596175e5cb397921566
author Duncan P. N. Exon Smith <dexonsmith@apple.com> Sat Dec 06 02:29:44 2014 +0000
committer Duncan P. N. Exon Smith <dexonsmith@apple.com> Sat Dec 06 02:29:44 2014 +0000
tree 78b922fc24c6d8a6c3ce848fe3914da5346dc9f6
parent 6980404cfe7c18ee03369102843ddeaf21e64fcc

IR: Disallow function-local metadata attachments

Metadata attachments to instructions cannot be function-local.

This is part of PR21532.

llvm-svn: 223574

llvm/lib/AsmParser/LLParser.cpp

diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp
index 93eb490..f44af67 100644
--- a/llvm/lib/AsmParser/LLParser.cpp
+++ b/llvm/lib/AsmParser/LLParser.cpp
@@ -62,6 +62,8 @@
             NumberedMetadata[SlotNo] == nullptr)
           return Error(MDList[i].Loc, "use of undefined metadata '!" +
                        Twine(SlotNo) + "'");
+        assert(!NumberedMetadata[SlotNo]->isFunctionLocal() &&
+               "Unexpected function-local metadata");
         Inst->setMetadata(MDList[i].MDKind, NumberedMetadata[SlotNo]);
       }
     }
@@ -1529,6 +1531,8 @@
       if (ParseMetadataListValue(ID, PFS))
         return true;
       assert(ID.Kind == ValID::t_MDNode);
+      if (ID.MDNodeVal->isFunctionLocal())
+        return TokError("unexpected function-local metadata");
       Inst->setMetadata(MDK, ID.MDNodeVal);
     } else {
       unsigned NodeID = 0;