commit 354abec3e6b6132c9456de39951e8de0632771cc
author Richard Smith <richard-llvm@metafoo.co.uk> Fri Dec 08 23:29:59 2017 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Fri Dec 08 23:29:59 2017 +0000
tree 191681e24af3adddd85524ec72439ac5c192d3f5
parent a5370fb82c8e2f9e7676a78677d2730b2512a082

Remove creation of out-of-bounds value of enumeration type (resulting in UB).

Also remove unnecessary initialization of out-parameters with this value, so
that MSan is able to catch errors appropriately.

llvm-svn: 320212

clang/lib/Sema/SemaExprCXX.cpp

diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index e4634d9..cd0d715 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -3840,7 +3840,7 @@
           << From->getSourceRange();
     }
 
-    CastKind Kind = CK_Invalid;
+    CastKind Kind;
     CXXCastPath BasePath;
     if (CheckPointerConversion(From, ToType, Kind, BasePath, CStyle))
       return ExprError();
@@ -3860,7 +3860,7 @@
   }
 
   case ICK_Pointer_Member: {
-    CastKind Kind = CK_Invalid;
+    CastKind Kind;
     CXXCastPath BasePath;
     if (CheckMemberPointerConversion(From, ToType, Kind, BasePath, CStyle))
       return ExprError();