commit 3666025880e248a9b48a463bfe4b5340e58e7cc9
author Rafael Espindola <rafael.espindola@gmail.com> Fri Apr 15 11:57:07 2016 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Fri Apr 15 11:57:07 2016 +0000
tree 895d9b0ee253959bad1c51886aee72668d06b9f6
parent 7ef36b5c15bed963491b04263d48b6a6e65c4666

Two small related fixes.

* A hidden undefined is not preemptable.
* It is always zero, so we don't need a dynamic reloc for it.

llvm-svn: 266424

lld/ELF/Symbols.cpp

diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index 9fe73b1..fe0e01e 100644
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -121,6 +121,9 @@
   if (isShared())
     return true;
 
+  if (getVisibility() != STV_DEFAULT)
+    return false;
+
   if (isUndefined()) {
     if (!isWeak())
       return true;
@@ -137,8 +140,6 @@
 
   if (!Config->Shared)
     return false;
-  if (getVisibility() != STV_DEFAULT)
-    return false;
   if (Config->Bsymbolic || (Config->BsymbolicFunctions && isFunc()))
     return false;
   return true;