commit 3b7499d104158e54634ac01c0e6826af49edc16a
author Fangrui Song <maskray@google.com> Fri May 25 00:11:15 2018 +0000
committer Fangrui Song <maskray@google.com> Fri May 25 00:11:15 2018 +0000
tree 79a320fa4e72a065bbf6a224c059e09524341eab
parent 7f0a05ada547b73a33f55d00a3fa984b2cd45a17

[llvm-symbolizer] Simplify. NFC

llvm-svn: 333247

llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

diff --git a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
index e3fd22e..1255e74 100644
--- a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
+++ b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
@@ -101,22 +101,17 @@
 
 static bool parseCommand(StringRef InputString, bool &IsData,
                          std::string &ModuleName, uint64_t &ModuleOffset) {
-  const char *kDataCmd = "DATA ";
-  const char *kCodeCmd = "CODE ";
   const char kDelimiters[] = " \n\r";
-  IsData = false;
   ModuleName = "";
-  const char *pos = InputString.data();
-  if (strncmp(pos, kDataCmd, strlen(kDataCmd)) == 0) {
-    IsData = true;
-    pos += strlen(kDataCmd);
-  } else if (strncmp(pos, kCodeCmd, strlen(kCodeCmd)) == 0) {
+  if (InputString.consume_front("CODE ")) {
     IsData = false;
-    pos += strlen(kCodeCmd);
+  } else if (InputString.consume_front("DATA ")) {
+    IsData = true;
   } else {
     // If no cmd, assume it's CODE.
     IsData = false;
   }
+  const char *pos = InputString.data();
   // Skip delimiters and parse input filename (if needed).
   if (ClBinaryName == "") {
     pos += strspn(pos, kDelimiters);
@@ -183,7 +178,7 @@
     if (ClPrintAddress) {
       outs() << "0x";
       outs().write_hex(ModuleOffset);
-      StringRef Delimiter = (ClPrettyPrint == true) ? ": " : "\n";
+      StringRef Delimiter = ClPrettyPrint ? ": " : "\n";
       outs() << Delimiter;
     }
     if (IsData) {