Make the Error class constructor protected
This is forcing to use Error::success(), which is in a wide majority
of cases a lot more readable.
Differential Revision: https://reviews.llvm.org/D26481
llvm-svn: 286561
diff --git a/lldb/source/Commands/CommandObjectDisassemble.cpp b/lldb/source/Commands/CommandObjectDisassemble.cpp
index 0795033..6273744 100644
--- a/lldb/source/Commands/CommandObjectDisassemble.cpp
+++ b/lldb/source/Commands/CommandObjectDisassemble.cpp
@@ -231,7 +231,7 @@
ExecutionContext *execution_context) {
if (!some_location_specified)
current_function = true;
- return Error();
+ return Error::success();
}
llvm::ArrayRef<OptionDefinition>
diff --git a/lldb/source/Commands/CommandObjectExpression.cpp b/lldb/source/Commands/CommandObjectExpression.cpp
index ba477cd..d98a3ee 100644
--- a/lldb/source/Commands/CommandObjectExpression.cpp
+++ b/lldb/source/Commands/CommandObjectExpression.cpp
@@ -303,7 +303,7 @@
return Error("as it does not refer to a pointer");
if (pointee.IsVoidType())
return Error("as it refers to a pointer to void");
- return Error();
+ return Error::success();
}
bool CommandObjectExpression::EvaluateExpression(const char *expr,
diff --git a/lldb/source/Core/ModuleList.cpp b/lldb/source/Core/ModuleList.cpp
index b980e15..7ad1f09 100644
--- a/lldb/source/Core/ModuleList.cpp
+++ b/lldb/source/Core/ModuleList.cpp
@@ -788,7 +788,7 @@
*did_create_ptr = true;
shared_module_list.ReplaceEquivalent(module_sp);
- return Error();
+ return Error::success();
}
}
} else {
diff --git a/lldb/source/Host/common/NativeBreakpoint.cpp b/lldb/source/Host/common/NativeBreakpoint.cpp
index d61a2f5..a2cc048 100644
--- a/lldb/source/Host/common/NativeBreakpoint.cpp
+++ b/lldb/source/Host/common/NativeBreakpoint.cpp
@@ -53,7 +53,7 @@
log->Printf("NativeBreakpoint::%s addr = 0x%" PRIx64
" already enabled, ignoring.",
__FUNCTION__, m_addr);
- return Error();
+ return Error::success();
}
// Log and enable.
@@ -85,7 +85,7 @@
log->Printf("NativeBreakpoint::%s addr = 0x%" PRIx64
" already disabled, ignoring.",
__FUNCTION__, m_addr);
- return Error();
+ return Error::success();
}
// Log and disable.
diff --git a/lldb/source/Host/common/NativeBreakpointList.cpp b/lldb/source/Host/common/NativeBreakpointList.cpp
index df5bce8..58e1c3e 100644
--- a/lldb/source/Host/common/NativeBreakpointList.cpp
+++ b/lldb/source/Host/common/NativeBreakpointList.cpp
@@ -40,7 +40,7 @@
__FUNCTION__, addr);
iter->second->AddRef();
- return Error();
+ return Error::success();
}
// Create a new breakpoint using the given create func.
@@ -205,7 +205,7 @@
// Disable it.
breakpoint_sp = iter->second;
- return Error();
+ return Error::success();
}
Error NativeBreakpointList::RemoveTrapsFromBuffer(lldb::addr_t addr, void *buf,
@@ -225,5 +225,5 @@
auto opcode_size = software_bp_sp->m_opcode_size;
::memcpy(opcode_addr, saved_opcodes, opcode_size);
}
- return Error();
+ return Error::success();
}
diff --git a/lldb/source/Host/common/NativeProcessProtocol.cpp b/lldb/source/Host/common/NativeProcessProtocol.cpp
index d77b8b2..a22d7f8 100644
--- a/lldb/source/Host/common/NativeProcessProtocol.cpp
+++ b/lldb/source/Host/common/NativeProcessProtocol.cpp
@@ -405,7 +405,7 @@
arch = module_specs.GetModuleSpecRefAtIndex(0).GetArchitecture();
if (arch.IsValid())
- return Error();
+ return Error::success();
else
return Error("failed to retrieve a valid architecture from the exe module");
}
diff --git a/lldb/source/Host/common/NativeWatchpointList.cpp b/lldb/source/Host/common/NativeWatchpointList.cpp
index 5948adf..be9d2eb 100644
--- a/lldb/source/Host/common/NativeWatchpointList.cpp
+++ b/lldb/source/Host/common/NativeWatchpointList.cpp
@@ -17,12 +17,12 @@
Error NativeWatchpointList::Add(addr_t addr, size_t size, uint32_t watch_flags,
bool hardware) {
m_watchpoints[addr] = {addr, size, watch_flags, hardware};
- return Error();
+ return Error::success();
}
Error NativeWatchpointList::Remove(addr_t addr) {
m_watchpoints.erase(addr);
- return Error();
+ return Error::success();
}
const NativeWatchpointList::WatchpointMap &
diff --git a/lldb/source/Host/common/SoftwareBreakpoint.cpp b/lldb/source/Host/common/SoftwareBreakpoint.cpp
index 3d57b7d..6cb8126 100644
--- a/lldb/source/Host/common/SoftwareBreakpoint.cpp
+++ b/lldb/source/Host/common/SoftwareBreakpoint.cpp
@@ -103,7 +103,7 @@
// breakpoint.
breakpoint_sp.reset(new SoftwareBreakpoint(process, addr, saved_opcode_bytes,
bp_opcode_bytes, bp_opcode_size));
- return Error();
+ return Error::success();
}
Error SoftwareBreakpoint::EnableSoftwareBreakpoint(
@@ -219,7 +219,7 @@
log->Printf("SoftwareBreakpoint::%s addr = 0x%" PRIx64 " -- SUCCESS",
__FUNCTION__, addr);
- return Error();
+ return Error::success();
}
// -------------------------------------------------------------------
diff --git a/lldb/source/Host/posix/FileSystem.cpp b/lldb/source/Host/posix/FileSystem.cpp
index aaa53ce..0567f60 100644
--- a/lldb/source/Host/posix/FileSystem.cpp
+++ b/lldb/source/Host/posix/FileSystem.cpp
@@ -62,7 +62,7 @@
} break;
case EEXIST: {
if (file_spec.IsDirectory())
- return Error(); // It is a directory and it already exists
+ return Error::success(); // It is a directory and it already exists
} break;
}
}
@@ -210,7 +210,7 @@
dst = FileSpec(real_path, false);
- return Error();
+ return Error::success();
}
#if defined(__NetBSD__)
diff --git a/lldb/source/Host/posix/MainLoopPosix.cpp b/lldb/source/Host/posix/MainLoopPosix.cpp
index 08c969e..59a7612 100644
--- a/lldb/source/Host/posix/MainLoopPosix.cpp
+++ b/lldb/source/Host/posix/MainLoopPosix.cpp
@@ -160,7 +160,7 @@
it->second.callback(*this); // Do the work
if (m_terminate_request)
- return Error();
+ return Error::success();
}
for (int fd : read_fds) {
@@ -175,8 +175,8 @@
it->second(*this); // Do the work
if (m_terminate_request)
- return Error();
+ return Error::success();
}
}
- return Error();
+ return Error::success();
}
diff --git a/lldb/source/Host/posix/PipePosix.cpp b/lldb/source/Host/posix/PipePosix.cpp
index 4e0810c..142f6c9 100644
--- a/lldb/source/Host/posix/PipePosix.cpp
+++ b/lldb/source/Host/posix/PipePosix.cpp
@@ -206,7 +206,7 @@
}
}
- return Error();
+ return Error::success();
}
int PipePosix::GetReadFileDescriptor() const { return m_fds[READ]; }
diff --git a/lldb/source/Host/windows/LockFileWindows.cpp b/lldb/source/Host/windows/LockFileWindows.cpp
index 0e7f595..11096bc 100644
--- a/lldb/source/Host/windows/LockFileWindows.cpp
+++ b/lldb/source/Host/windows/LockFileWindows.cpp
@@ -31,7 +31,7 @@
if (!::GetOverlappedResult(file_handle, &overlapped, &bytes, TRUE))
return Error(::GetLastError(), eErrorTypeWin32);
- return Error();
+ return Error::success();
}
} // namespace
@@ -74,5 +74,5 @@
if (!::GetOverlappedResult(m_file, &overlapped, &bytes, TRUE))
return Error(::GetLastError(), eErrorTypeWin32);
- return Error();
+ return Error::success();
}
diff --git a/lldb/source/Host/windows/PipeWindows.cpp b/lldb/source/Host/windows/PipeWindows.cpp
index 407f046..64b6584 100644
--- a/lldb/source/Host/windows/PipeWindows.cpp
+++ b/lldb/source/Host/windows/PipeWindows.cpp
@@ -161,7 +161,7 @@
ZeroMemory(&m_write_overlapped, sizeof(m_write_overlapped));
}
- return Error();
+ return Error::success();
}
int PipeWindows::GetReadFileDescriptor() const { return m_read_fd; }
@@ -217,7 +217,7 @@
CloseWriteFileDescriptor();
}
-Error PipeWindows::Delete(llvm::StringRef name) { return Error(); }
+Error PipeWindows::Delete(llvm::StringRef name) { return Error::success(); }
bool PipeWindows::CanRead() const { return (m_read != INVALID_HANDLE_VALUE); }
@@ -273,7 +273,7 @@
return Error(::GetLastError(), eErrorTypeWin32);
bytes_read = sys_bytes_read;
- return Error();
+ return Error::success();
}
Error PipeWindows::Write(const void *buf, size_t num_bytes,
@@ -291,5 +291,5 @@
&sys_bytes_written, TRUE);
if (!result)
return Error(::GetLastError(), eErrorTypeWin32);
- return Error();
+ return Error::success();
}
diff --git a/lldb/source/Interpreter/OptionGroupVariable.cpp b/lldb/source/Interpreter/OptionGroupVariable.cpp
index c257506..a3150d1 100644
--- a/lldb/source/Interpreter/OptionGroupVariable.cpp
+++ b/lldb/source/Interpreter/OptionGroupVariable.cpp
@@ -59,13 +59,13 @@
if (DataVisualization::NamedSummaryFormats::GetSummaryFormat(
ConstString(str), summary_sp) == false)
return Error("must specify a valid named summary");
- return Error();
+ return Error::success();
}
static Error ValidateSummaryString(const char *str, void *) {
if (!str || !str[0])
return Error("must specify a non-empty summary string");
- return Error();
+ return Error::success();
}
OptionGroupVariable::OptionGroupVariable(bool show_frame_options)
diff --git a/lldb/source/Interpreter/OptionValueString.cpp b/lldb/source/Interpreter/OptionValueString.cpp
index e61ead0..b5ce38c 100644
--- a/lldb/source/Interpreter/OptionValueString.cpp
+++ b/lldb/source/Interpreter/OptionValueString.cpp
@@ -133,7 +133,7 @@
return error;
}
m_current_value.assign(value);
- return Error();
+ return Error::success();
}
Error OptionValueString::AppendToCurrentValue(const char *value) {
@@ -148,5 +148,5 @@
} else
m_current_value.append(value);
}
- return Error();
+ return Error::success();
}
diff --git a/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp b/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
index fcbba93..73c3cca 100644
--- a/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
+++ b/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
@@ -213,7 +213,7 @@
}
// AD: Needs to be updated?
-Error DynamicLoaderHexagonDYLD::CanLoadImage() { return Error(); }
+Error DynamicLoaderHexagonDYLD::CanLoadImage() { return Error::success(); }
void DynamicLoaderHexagonDYLD::UpdateLoadedSections(ModuleSP module,
addr_t link_map_addr,
diff --git a/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp b/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
index 8678f61..9af4646 100644
--- a/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
+++ b/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
@@ -221,7 +221,7 @@
}
}
-Error DynamicLoaderPOSIXDYLD::CanLoadImage() { return Error(); }
+Error DynamicLoaderPOSIXDYLD::CanLoadImage() { return Error::success(); }
void DynamicLoaderPOSIXDYLD::UpdateLoadedSections(ModuleSP module,
addr_t link_map_addr,
diff --git a/lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp b/lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
index 20bf360..09ed903 100644
--- a/lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
+++ b/lldb/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
@@ -61,7 +61,7 @@
void DynamicLoaderWindowsDYLD::DidLaunch() {}
-Error DynamicLoaderWindowsDYLD::CanLoadImage() { return Error(); }
+Error DynamicLoaderWindowsDYLD::CanLoadImage() { return Error::success(); }
ConstString DynamicLoaderWindowsDYLD::GetPluginName() {
return GetPluginNameStatic();
diff --git a/lldb/source/Plugins/Platform/Android/AdbClient.cpp b/lldb/source/Plugins/Platform/Android/AdbClient.cpp
index 79ad8f5..592bc84 100644
--- a/lldb/source/Plugins/Platform/Android/AdbClient.cpp
+++ b/lldb/source/Plugins/Platform/Android/AdbClient.cpp
@@ -381,7 +381,7 @@
std::string(output_buf.begin(), output_buf.end()).c_str());
}
- return Error();
+ return Error::success();
}
Error AdbClient::Shell(const char *command, uint32_t timeout_ms,
@@ -412,7 +412,7 @@
dst.close();
if (!dst)
return Error("Failed to write file %s", output_filename.c_str());
- return Error();
+ return Error::success();
}
std::unique_ptr<AdbClient::SyncService>
@@ -536,7 +536,7 @@
mode = extractor.GetU32(&offset);
size = extractor.GetU32(&offset);
mtime = extractor.GetU32(&offset);
- return Error();
+ return Error::success();
}
Error AdbClient::SyncService::PullFile(const FileSpec &remote_file,
@@ -641,7 +641,7 @@
} else
return Error("Pull failed with unknown response: %s", response_id.c_str());
- return Error();
+ return Error::success();
}
Error AdbClient::SyncService::ReadAllBytes(void *buffer, size_t size) {
diff --git a/lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp b/lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
index a870929..43720c0 100644
--- a/lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
+++ b/lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
@@ -252,7 +252,7 @@
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
//------------------------------------------------------------------
diff --git a/lldb/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp b/lldb/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp
index 69f5c29..017a1bf 100644
--- a/lldb/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp
+++ b/lldb/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp
@@ -179,7 +179,7 @@
Error PlatformKalimba::GetFileWithUUID(const FileSpec & /*platform_file*/,
const UUID * /*uuid_ptr*/,
FileSpec & /*local_file*/) {
- return Error();
+ return Error::success();
}
//------------------------------------------------------------------
diff --git a/lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp b/lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
index 5b6bc35..b8fae14 100644
--- a/lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
+++ b/lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
@@ -341,7 +341,7 @@
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
//------------------------------------------------------------------
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
index e6da63e..0b5d394 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
@@ -71,7 +71,7 @@
if (spawned) {
launch_info.SetProcessID(spawned.GetPID());
- return Error();
+ return Error::success();
} else
return spawned.GetError();
#else
@@ -164,7 +164,7 @@
Error PlatformAppleSimulator::DisconnectRemote() {
#if defined(__APPLE__)
m_device.reset();
- return Error();
+ return Error::success();
#else
Error err;
err.SetErrorString(UNSUPPORTED_ERROR);
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
index a92a8da..8cecd38 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
@@ -393,7 +393,7 @@
module_spec.GetArchitecture());
module_sp.reset(new Module(local_spec));
module_sp->SetPlatformFileSpec(module_spec.GetFileSpec());
- return Error();
+ return Error::success();
}
}
@@ -433,7 +433,7 @@
(IsHost() ? "host" : "remote"),
module_spec.GetFileSpec().GetDirectory().AsCString(),
module_spec.GetFileSpec().GetFilename().AsCString());
- return Error();
+ return Error::success();
}
// bring in the remote module file
@@ -455,7 +455,7 @@
ModuleSpec local_spec(module_cache_spec, module_spec.GetArchitecture());
module_sp.reset(new Module(local_spec));
module_sp->SetPlatformFileSpec(module_spec.GetFileSpec());
- return Error();
+ return Error::success();
} else
return Error("unable to obtain valid module file");
} else
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
index 89b61bf..c506302 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
@@ -247,7 +247,7 @@
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
lldb_private::Error
@@ -264,7 +264,7 @@
if (local_os_build.compare(remote_os_build) == 0) {
// same OS version: the local file is good enough
local_file = platform_file;
- return Error();
+ return Error::success();
} else {
// try to find the file in the cache
std::string cache_path(GetLocalCacheDirectory());
@@ -273,7 +273,7 @@
FileSpec module_cache_spec(cache_path, false);
if (module_cache_spec.Exists()) {
local_file = module_cache_spec;
- return Error();
+ return Error::success();
}
// bring in the remote module file
FileSpec module_cache_folder =
@@ -288,13 +288,13 @@
return err;
if (module_cache_spec.Exists()) {
local_file = module_cache_spec;
- return Error();
+ return Error::success();
} else
return Error("unable to obtain valid module file");
}
}
local_file = platform_file;
- return Error();
+ return Error::success();
}
bool PlatformMacOSX::GetSupportedArchitectureAtIndex(uint32_t idx,
diff --git a/lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp b/lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
index cb3c124..b7fa7aa 100644
--- a/lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
+++ b/lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
@@ -244,7 +244,7 @@
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
//------------------------------------------------------------------
diff --git a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
index b751de7..100500f 100644
--- a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
+++ b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
@@ -207,7 +207,7 @@
if (IsHost()) {
if (FileSpec::Equal(source, destination, true))
- return Error();
+ return Error::success();
// cp src dst
// chown uid:gid dst
std::string src_path(source.GetPath());
@@ -223,10 +223,10 @@
if (status != 0)
return Error("unable to perform copy");
if (uid == UINT32_MAX && gid == UINT32_MAX)
- return Error();
+ return Error::success();
if (chown_file(this, dst_path.c_str(), uid, gid) != 0)
return Error("unable to perform chown");
- return Error();
+ return Error::success();
} else if (m_remote_platform_sp) {
if (GetSupportsRSync()) {
std::string src_path(source.GetPath());
@@ -254,7 +254,7 @@
// Don't chown a local file for a remote system
// if (chown_file(this,dst_path.c_str(),uid,gid) != 0)
// return Error("unable to perform chown");
- return Error();
+ return Error::success();
}
// if we are still here rsync has failed - let's try the slow way before
// giving up
@@ -323,7 +323,7 @@
RunShellCommand(cp_command.GetData(), NULL, &status, NULL, NULL, 10);
if (status != 0)
return Error("unable to perform copy");
- return Error();
+ return Error::success();
} else if (m_remote_platform_sp) {
if (GetSupportsRSync()) {
StreamString command;
@@ -343,7 +343,7 @@
int retcode;
Host::RunShellCommand(command.GetData(), NULL, &retcode, NULL, NULL, 60);
if (retcode == 0)
- return Error();
+ return Error::success();
// If we are here, rsync has failed - let's try the slow way before giving
// up
}
@@ -745,7 +745,7 @@
if (result_valobj_sp->GetError().Fail())
return result_valobj_sp->GetError();
- return Error();
+ return Error::success();
}
uint32_t PlatformPOSIX::DoLoadImage(lldb_private::Process *process,
@@ -833,7 +833,7 @@
return Error("expression failed: \"%s\"", expr.GetData());
process->ResetImageToken(image_token);
}
- return Error();
+ return Error::success();
}
lldb::ProcessSP PlatformPOSIX::ConnectProcess(const char *connect_url,
diff --git a/lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp b/lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
index d25bb7b..534c773 100644
--- a/lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
+++ b/lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
@@ -527,7 +527,7 @@
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
Error PlatformWindows::GetSharedModule(
diff --git a/lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp b/lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
index 8b9972f..007ce1a 100644
--- a/lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
+++ b/lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
@@ -196,7 +196,7 @@
FileSpec &local_file) {
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
//------------------------------------------------------------------
@@ -482,7 +482,7 @@
Error PlatformRemoteGDBServer::KillProcess(const lldb::pid_t pid) {
if (!KillSpawnedProcess(pid))
return Error("failed to kill remote spawned process");
- return Error();
+ return Error::success();
}
lldb::ProcessSP PlatformRemoteGDBServer::DebugProcess(
diff --git a/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp b/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
index 82e45a5..7680dfe 100644
--- a/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
@@ -150,7 +150,7 @@
else
m_monitor->Resume(GetID(), m_resume_signo);
- return Error();
+ return Error::success();
}
bool ProcessFreeBSD::UpdateThreadList(ThreadList &old_thread_list,
diff --git a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
index 8494077..7a3696a 100644
--- a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
@@ -1364,13 +1364,13 @@
// If setting the breakpoint fails because next_pc is out of
// the address space, ignore it and let the debugee segfault.
if (error.GetError() == EIO || error.GetError() == EFAULT) {
- return Error();
+ return Error::success();
} else if (error.Fail())
return error;
m_threads_stepping_with_breakpoint.insert({thread.GetID(), next_pc});
- return Error();
+ return Error::success();
}
bool NativeProcessLinux::SupportHardwareSingleStepping() const {
@@ -1453,7 +1453,7 @@
}
}
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::Halt() {
@@ -1553,7 +1553,7 @@
StopRunningThreads(deferred_signal_thread_sp->GetID());
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::Kill() {
@@ -1677,7 +1677,7 @@
if (name)
memory_region_info.SetName(name);
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::GetMemoryRegionInfo(lldb::addr_t load_addr,
@@ -1841,7 +1841,7 @@
if (InferiorCallMmap(this, addr, 0, size, prot,
eMmapFlagsAnon | eMmapFlagsPrivate, -1, 0)) {
m_addr_to_mmap_size[addr] = size;
- return Error();
+ return Error::success();
} else {
addr = LLDB_INVALID_ADDRESS;
return Error("unable to allocate %" PRIu64
@@ -1886,11 +1886,11 @@
case llvm::Triple::x86:
case llvm::Triple::x86_64:
actual_opcode_size = static_cast<uint32_t>(sizeof(g_i386_opcode));
- return Error();
+ return Error::success();
case llvm::Triple::systemz:
actual_opcode_size = static_cast<uint32_t>(sizeof(g_s390x_opcode));
- return Error();
+ return Error::success();
case llvm::Triple::arm:
case llvm::Triple::aarch64:
@@ -1900,7 +1900,7 @@
case llvm::Triple::mipsel:
// On these architectures the PC don't get updated for breakpoint hits
actual_opcode_size = 0;
- return Error();
+ return Error::success();
default:
assert(false && "CPU type not supported!");
@@ -1935,18 +1935,18 @@
case llvm::Triple::aarch64:
trap_opcode_bytes = g_aarch64_opcode;
actual_opcode_size = sizeof(g_aarch64_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::arm:
switch (trap_opcode_size_hint) {
case 2:
trap_opcode_bytes = g_thumb_breakpoint_opcode;
actual_opcode_size = sizeof(g_thumb_breakpoint_opcode);
- return Error();
+ return Error::success();
case 4:
trap_opcode_bytes = g_arm_breakpoint_opcode;
actual_opcode_size = sizeof(g_arm_breakpoint_opcode);
- return Error();
+ return Error::success();
default:
assert(false && "Unrecognised trap opcode size hint!");
return Error("Unrecognised trap opcode size hint!");
@@ -1956,24 +1956,24 @@
case llvm::Triple::x86_64:
trap_opcode_bytes = g_i386_opcode;
actual_opcode_size = sizeof(g_i386_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::mips:
case llvm::Triple::mips64:
trap_opcode_bytes = g_mips64_opcode;
actual_opcode_size = sizeof(g_mips64_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::mipsel:
case llvm::Triple::mips64el:
trap_opcode_bytes = g_mips64el_opcode;
actual_opcode_size = sizeof(g_mips64el_opcode);
- return Error();
+ return Error::success();
case llvm::Triple::systemz:
trap_opcode_bytes = g_s390x_opcode;
actual_opcode_size = sizeof(g_s390x_opcode);
- return Error();
+ return Error::success();
default:
assert(false && "CPU type not supported!");
@@ -2156,7 +2156,7 @@
success ? "Success" : strerror(errno));
if (success)
- return Error();
+ return Error::success();
// else
// the call failed for some reason, let's retry the read using ptrace
// api.
@@ -2207,7 +2207,7 @@
if (log)
ProcessPOSIXLog::DecNestLevel();
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::ReadMemoryWithoutTrap(lldb::addr_t addr, void *buf,
@@ -2303,7 +2303,7 @@
Error NativeProcessLinux::Detach(lldb::tid_t tid) {
if (tid == LLDB_INVALID_THREAD_ID)
- return Error();
+ return Error::success();
return PtraceWrapper(PTRACE_DETACH, tid);
}
@@ -2414,7 +2414,7 @@
"NativeProcessLinux::%s pid %" PRIu64
" no lldb breakpoint found at current pc with adjustment: 0x%" PRIx64,
__FUNCTION__, GetID(), breakpoint_addr);
- return Error();
+ return Error::success();
}
// If the breakpoint is not a software breakpoint, nothing to do.
@@ -2424,7 +2424,7 @@
" breakpoint found at 0x%" PRIx64
", not software, nothing to adjust",
__FUNCTION__, GetID(), breakpoint_addr);
- return Error();
+ return Error::success();
}
//
@@ -2440,7 +2440,7 @@
" breakpoint found at 0x%" PRIx64
", it is software, but the size is zero, nothing to do (unexpected)",
__FUNCTION__, GetID(), breakpoint_addr);
- return Error();
+ return Error::success();
}
// Change the program counter.
@@ -2488,7 +2488,7 @@
return Error("Module file (%s) not found in /proc/%" PRIu64 "/maps file!",
module_file_spec.GetFilename().AsCString(), GetID());
- return Error();
+ return Error::success();
}
Error NativeProcessLinux::GetFileLoadAddress(const llvm::StringRef &file_name,
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
index 9e85713..4566493 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
@@ -263,7 +263,7 @@
if (error.Fail())
return error;
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized to be a GPR or an FPR, "
@@ -679,7 +679,7 @@
}
}
- return Error();
+ return Error::success();
}
uint32_t NativeRegisterContextLinux_arm::GetWatchpointSize(uint32_t wp_index) {
@@ -730,12 +730,12 @@
if (WatchpointIsEnabled(wp_index) && trap_addr >= watch_addr &&
trap_addr < watch_addr + watch_size) {
m_hwp_regs[wp_index].hit_addr = trap_addr;
- return Error();
+ return Error::success();
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
lldb::addr_t
@@ -774,7 +774,7 @@
Error error;
if (!m_refresh_hwdebug_info) {
- return Error();
+ return Error::success();
}
unsigned int cap_val;
@@ -862,7 +862,7 @@
return error;
value.SetUInt32(m_gpr_arm[offset / sizeof(uint32_t)]);
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_arm::DoWriteRegisterValue(
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
index cb0700d..c0fdb74 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
@@ -276,7 +276,7 @@
if (error.Fail())
return error;
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized to be a GPR or an FPR, "
@@ -671,7 +671,7 @@
}
}
- return Error();
+ return Error::success();
}
uint32_t
@@ -722,12 +722,12 @@
if (WatchpointIsEnabled(wp_index) && trap_addr >= watch_addr &&
trap_addr < watch_addr + watch_size) {
m_hwp_regs[wp_index].hit_addr = trap_addr;
- return Error();
+ return Error::success();
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
lldb::addr_t
@@ -764,7 +764,7 @@
Error NativeRegisterContextLinux_arm64::ReadHardwareDebugInfo() {
if (!m_refresh_hwdebug_info) {
- return Error();
+ return Error::success();
}
::pid_t tid = m_thread.GetID();
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
index c050a2e..bbd4578 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
@@ -932,7 +932,7 @@
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_mips64::IsWatchpointVacant(uint32_t wp_index,
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
index 7ec4dc5..105fa9b 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
@@ -222,7 +222,7 @@
assert(false && "Unhandled data size.");
return Error("unhandled byte size: %" PRIu32, reg_info->byte_size);
}
- return Error();
+ return Error::success();
}
if (IsFPR(reg)) {
@@ -245,7 +245,7 @@
assert(false && "Unhandled data size.");
return Error("unhandled byte size: %" PRIu32, reg_info->byte_size);
}
- return Error();
+ return Error::success();
}
if (reg == lldb_last_break_s390x) {
@@ -255,7 +255,7 @@
return error;
reg_value.SetUInt64(last_break);
- return Error();
+ return Error::success();
}
if (reg == lldb_system_call_s390x) {
@@ -265,7 +265,7 @@
return error;
reg_value.SetUInt32(system_call);
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized");
@@ -511,7 +511,7 @@
if (m_watchpoint_addr == LLDB_INVALID_ADDRESS) {
is_hit = false;
- return Error();
+ return Error::success();
}
Error error = PeekUserArea(offsetof(user_regs_struct, per_info.lowcore),
@@ -531,7 +531,7 @@
sizeof(per_lowcore));
}
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_s390x::GetWatchpointHitIndex(
@@ -548,7 +548,7 @@
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_s390x::IsWatchpointVacant(uint32_t wp_index,
@@ -558,7 +558,7 @@
is_vacant = m_watchpoint_addr == LLDB_INVALID_ADDRESS;
- return Error();
+ return Error::success();
}
bool NativeRegisterContextLinux_s390x::ClearHardwareWatchpoint(
@@ -589,7 +589,7 @@
Error NativeRegisterContextLinux_s390x::ClearAllHardwareWatchpoints() {
if (ClearHardwareWatchpoint(0))
- return Error();
+ return Error::success();
return Error("Clearing all hardware watchpoints failed.");
}
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
index 37e748d..e9bc296 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
@@ -626,7 +626,7 @@
if (!CopyMPXtoXSTATE(reg_index))
return Error("CopyMPXtoXSTATE() failed");
}
- return Error();
+ return Error::success();
}
return Error("failed - register wasn't recognized to be a GPR or an FPR, "
"write strategy unknown");
@@ -1035,7 +1035,7 @@
}
}
wp_index = LLDB_INVALID_INDEX32;
- return Error();
+ return Error::success();
}
Error NativeRegisterContextLinux_x86_64::IsWatchpointVacant(uint32_t wp_index,
diff --git a/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
index d18d3c1..6b4426b 100644
--- a/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
+++ b/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
@@ -167,7 +167,7 @@
if (!hardware)
return Error("not implemented");
if (m_state == eStateLaunching)
- return Error();
+ return Error::success();
Error error = RemoveWatchpoint(addr);
if (error.Fail())
return error;
@@ -176,17 +176,17 @@
if (wp_index == LLDB_INVALID_INDEX32)
return Error("Setting hardware watchpoint failed.");
m_watchpoint_index_map.insert({addr, wp_index});
- return Error();
+ return Error::success();
}
Error NativeThreadLinux::RemoveWatchpoint(lldb::addr_t addr) {
auto wp = m_watchpoint_index_map.find(addr);
if (wp == m_watchpoint_index_map.end())
- return Error();
+ return Error::success();
uint32_t wp_index = wp->second;
m_watchpoint_index_map.erase(wp);
if (GetRegisterContext()->ClearHardwareWatchpoint(wp_index))
- return Error();
+ return Error::success();
return Error("Clearing hardware watchpoint failed.");
}
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
index 77b9fc8..2decd29 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
@@ -414,7 +414,7 @@
return m_dyld_ap.get();
}
-Error ProcessKDP::WillResume() { return Error(); }
+Error ProcessKDP::WillResume() { return Error::success(); }
Error ProcessKDP::DoResume() {
Error error;
diff --git a/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp b/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
index 7ddc586..8fe93fa 100644
--- a/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
+++ b/lldb/source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
@@ -427,7 +427,7 @@
WINDOWS_LOG_PROCESS,
"DoDetach called while state = %u, but there is no active session.",
private_state);
- return Error();
+ return Error::success();
}
debugger_thread = m_session_data->m_debugger;
@@ -477,7 +477,7 @@
WINDOWS_LOG_PROCESS,
"DoDestroy called while state = %u, but there is no active session.",
private_state);
- return Error();
+ return Error::success();
}
debugger_thread = m_session_data->m_debugger;
diff --git a/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp b/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
index 128c4c1..5aaeb98 100644
--- a/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
+++ b/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
@@ -587,7 +587,7 @@
return m_impl_up->RefreshStateAfterStop();
}
-Error ProcessWinMiniDump::DoDestroy() { return Error(); }
+Error ProcessWinMiniDump::DoDestroy() { return Error::success(); }
bool ProcessWinMiniDump::IsAlive() { return true; }
diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
index 840a792..d9fa3f8 100644
--- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -258,7 +258,7 @@
void ProcessElfCore::RefreshStateAfterStop() {}
-Error ProcessElfCore::DoDestroy() { return Error(); }
+Error ProcessElfCore::DoDestroy() { return Error::success(); }
//------------------------------------------------------------------
// Process Queries
@@ -304,7 +304,7 @@
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
}
- return Error();
+ return Error::success();
}
region_info.GetRange().SetRangeBase(load_addr);
@@ -313,7 +313,7 @@
region_info.SetWritable(MemoryRegionInfo::eNo);
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
- return Error();
+ return Error::success();
}
size_t ProcessElfCore::DoReadMemory(lldb::addr_t addr, void *buf, size_t size,
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
index 49733a5..f0494a8 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -2672,7 +2672,7 @@
response.GetEscapedBinaryData(output);
if (command_output)
command_output->assign(output);
- return Error();
+ return Error::success();
}
return Error("unable to send packet");
}
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
index 0897611..440651f 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
@@ -197,13 +197,13 @@
__FUNCTION__);
m_process_launch_info.SetArguments(const_cast<const char **>(args), true);
- return Error();
+ return Error::success();
}
Error GDBRemoteCommunicationServerLLGS::SetLaunchFlags(
unsigned int launch_flags) {
m_process_launch_info.GetFlags().Set(launch_flags);
- return Error();
+ return Error::success();
}
Error GDBRemoteCommunicationServerLLGS::LaunchProcess() {
@@ -988,7 +988,7 @@
return error;
}
- return Error();
+ return Error::success();
}
void GDBRemoteCommunicationServerLLGS::StartSTDIOForwarding() {
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index c0fbccb..07d3080 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -1252,7 +1252,7 @@
m_continue_S_tids.clear();
m_jstopinfo_sp.reset();
m_jthreadsinfo_sp.reset();
- return Error();
+ return Error::success();
}
Error ProcessGDBRemote::DoResume() {
@@ -3246,7 +3246,7 @@
const ProcessInfo &process_info) {
// Make sure we aren't already connected?
if (m_gdb_comm.IsConnected())
- return Error();
+ return Error::success();
PlatformSP platform_sp(GetTarget().GetPlatform());
if (platform_sp && !platform_sp->IsHost())
@@ -4408,7 +4408,7 @@
XMLNode root_element = doc.GetRootElement("library-list-svr4");
if (!root_element)
- return Error();
+ return Error::success();
// main link map structure
llvm::StringRef main_lm = root_element.GetAttributeValue("main-lm");
@@ -4494,7 +4494,7 @@
XMLNode root_element = doc.GetRootElement("library-list");
if (!root_element)
- return Error();
+ return Error::success();
root_element.ForEachChildElementWithName(
"library", [log, &list](const XMLNode &library) -> bool {
@@ -4538,7 +4538,7 @@
return Error(0, ErrorType::eErrorTypeGeneric);
}
- return Error();
+ return Error::success();
}
lldb::ModuleSP ProcessGDBRemote::LoadModuleAtAddress(const FileSpec &file,
@@ -4662,7 +4662,7 @@
// The file is not loaded into the inferior
is_loaded = false;
load_addr = LLDB_INVALID_ADDRESS;
- return Error();
+ return Error::success();
}
return Error(
@@ -4672,7 +4672,7 @@
if (response.IsNormalResponse()) {
is_loaded = true;
load_addr = response.GetHexMaxU64(false, LLDB_INVALID_ADDRESS);
- return Error();
+ return Error::success();
}
return Error("Unknown error happened during sending the load address packet");
diff --git a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
index f83499c..1b32117 100644
--- a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
+++ b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
@@ -461,7 +461,7 @@
// SetThreadStopInfo (m_last_stop_packet);
}
-Error ProcessMachCore::DoDestroy() { return Error(); }
+Error ProcessMachCore::DoDestroy() { return Error::success(); }
//------------------------------------------------------------------
// Process Queries
@@ -564,7 +564,7 @@
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
}
- return Error();
+ return Error::success();
}
region_info.GetRange().SetRangeBase(load_addr);
@@ -573,7 +573,7 @@
region_info.SetWritable(MemoryRegionInfo::eNo);
region_info.SetExecutable(MemoryRegionInfo::eNo);
region_info.SetMapped(MemoryRegionInfo::eNo);
- return Error();
+ return Error::success();
}
void ProcessMachCore::Clear() { m_thread_list.Clear(); }
diff --git a/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp b/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
index 46d8df8..5b390d8 100644
--- a/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
+++ b/lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
@@ -133,7 +133,7 @@
uint32_t ProcessMinidump::GetPluginVersion() { return 1; }
-Error ProcessMinidump::DoDestroy() { return Error(); }
+Error ProcessMinidump::DoDestroy() { return Error::success(); }
void ProcessMinidump::RefreshStateAfterStop() {
if (!m_active_exception)
diff --git a/lldb/source/Target/Platform.cpp b/lldb/source/Target/Platform.cpp
index 270400a..07d5968 100644
--- a/lldb/source/Target/Platform.cpp
+++ b/lldb/source/Target/Platform.cpp
@@ -172,7 +172,7 @@
const UUID *uuid_ptr, FileSpec &local_file) {
// Default to the local case
local_file = platform_file;
- return Error();
+ return Error::success();
}
FileSpecList
@@ -1089,7 +1089,7 @@
"they are controlled by a process plugin");
}
Host::Kill(pid, SIGTERM);
- return Error();
+ return Error::success();
}
lldb::ProcessSP
@@ -1597,7 +1597,7 @@
const auto error = module_resolver(resolved_module_spec);
if (error.Fail()) {
if (GetCachedSharedModule(resolved_module_spec, module_sp, did_create_ptr))
- return Error();
+ return Error::success();
}
return error;
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 67c1489..60e1e33 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -3359,7 +3359,7 @@
RestoreProcessEvents();
SetExitStatus(SIGKILL, "Cancelled async attach.");
Destroy(false);
- return Error();
+ return Error::success();
}
// Wait for 10 second for the process to stop.
@@ -3375,7 +3375,7 @@
BroadcastEvent(event_sp);
- return Error();
+ return Error::success();
}
Error Process::StopForDestroyOrDetach(lldb::EventSP &exit_event_sp) {
diff --git a/lldb/source/Target/Thread.cpp b/lldb/source/Target/Thread.cpp
index 8e2a9c7..4034ed3 100644
--- a/lldb/source/Target/Thread.cpp
+++ b/lldb/source/Target/Thread.cpp
@@ -1766,7 +1766,7 @@
if (!reg_ctx->SetPC(dest))
return Error("Cannot change PC to target address.");
- return Error();
+ return Error::success();
}
void Thread::DumpUsingSettingsFormat(Stream &strm, uint32_t frame_idx,
diff --git a/lldb/source/Utility/ModuleCache.cpp b/lldb/source/Utility/ModuleCache.cpp
index 889cd8f..c53be90 100644
--- a/lldb/source/Utility/ModuleCache.cpp
+++ b/lldb/source/Utility/ModuleCache.cpp
@@ -70,7 +70,7 @@
if (!dir_path.IsDirectory())
return Error("Invalid existing path");
- return Error();
+ return Error::success();
}
return FileSystem::MakeDirectory(dir_path, eFilePermissionsDirectoryDefault);
@@ -141,7 +141,7 @@
platform_module_spec.GetPath().c_str());
if (sysroot_module_path_spec.Exists()) {
if (!delete_existing)
- return Error();
+ return Error::success();
DecrementRefExistingModule(root_dir_spec, sysroot_module_path_spec);
}
@@ -210,7 +210,7 @@
if (error.Fail())
return Error("Failed to create link to %s: %s",
module_file_path.GetPath().c_str(), error.AsCString());
- return Error();
+ return Error::success();
}
Error ModuleCache::Get(const FileSpec &root_dir_spec, const char *hostname,
@@ -221,7 +221,7 @@
if (find_it != m_loaded_modules.end()) {
cached_module_sp = (*find_it).second.lock();
if (cached_module_sp)
- return Error();
+ return Error::success();
m_loaded_modules.erase(find_it);
}
@@ -263,7 +263,7 @@
m_loaded_modules.insert(
std::make_pair(module_spec.GetUUID().GetAsString(), cached_module_sp));
- return Error();
+ return Error::success();
}
Error ModuleCache::GetAndPut(const FileSpec &root_dir_spec,
@@ -320,7 +320,7 @@
// module might
// contain the necessary symbols and the debugging is also possible without
// a symfile.
- return Error();
+ return Error::success();
error = Put(root_dir_spec, escaped_hostname.c_str(), module_spec,
tmp_download_sym_file_spec,
@@ -332,5 +332,5 @@
FileSpec symfile_spec = GetSymbolFileSpec(cached_module_sp->GetFileSpec());
cached_module_sp->SetSymbolFileFileSpec(symfile_spec);
- return Error();
+ return Error::success();
}