commit 41bb43252b18f9687990b2dd5c53c8270c785a62
author Rafael Espindola <rafael.espindola@gmail.com> Tue Jun 30 04:08:37 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Tue Jun 30 04:08:37 2015 +0000
tree 495370f702fa41568544f4736c15c4dd24c5cc23
parent 8465c00762751d3145220e29a3a503b2dab41b40

Don't return error_code from a function that doesn't fail.

llvm-svn: 241042

llvm/tools/llvm-objdump/llvm-objdump.cpp

diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index b17cb0b..dde7e55 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -931,7 +931,7 @@
 
           // Stop when rel_cur's address is past the current instruction.
           if (addr >= Index + Size) break;
-          if (error(rel_cur->getTypeName(name))) goto skip_print_rel;
+          rel_cur->getTypeName(name);
           if (error(getRelocationValueString(*rel_cur, val)))
             goto skip_print_rel;
           outs() << format(Fmt.data(), SectionAddr + addr) << name
@@ -967,8 +967,7 @@
       SmallString<32> valuestr;
       if (hidden)
         continue;
-      if (error(Reloc.getTypeName(relocname)))
-        continue;
+      Reloc.getTypeName(relocname);
       if (error(getRelocationValueString(Reloc, valuestr)))
         continue;
       outs() << format(Fmt.data(), address) << " " << relocname << " "