Punt on unifying symbolic lvalues. This won't be needed for many checkers.
llvm-svn: 47489
diff --git a/clang/Analysis/GRSimpleVals.cpp b/clang/Analysis/GRSimpleVals.cpp
index 775d099..04a13e3 100644
--- a/clang/Analysis/GRSimpleVals.cpp
+++ b/clang/Analysis/GRSimpleVals.cpp
@@ -225,11 +225,12 @@
return nonlval::SymIntConstraintVal(C);
}
- // FIXME: Implement unification
- return UnknownVal();
- //assert (!isa<lval::SymbolVal>(R) && "FIXME: Implement unification.");
-
- break;
+ // FIXME: Implement == for lval Symbols. This is mainly useful
+ // in iterator loops when traversing a buffer, e.g. while(z != zTerm).
+ // Since this is not useful for many checkers we'll punt on this for
+ // now.
+
+ return UnknownVal();
}
case lval::DeclValKind:
@@ -278,7 +279,12 @@
return nonlval::SymIntConstraintVal(C);
}
- assert (!isa<lval::SymbolVal>(R) && "FIXME: Implement sym !=.");
+ // FIXME: Implement != for lval Symbols. This is mainly useful
+ // in iterator loops when traversing a buffer, e.g. while(z != zTerm).
+ // Since this is not useful for many checkers we'll punt on this for
+ // now.
+
+ return UnknownVal();
break;
}