[Support] Make error banner optional in logAllUnhandledErrors
In a lot of places an empty string was passed as the ErrorBanner to
logAllUnhandledErrors. This patch makes that argument optional to
simplify the call sites.
llvm-svn: 346604
diff --git a/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
index ae408a0..09224c2 100644
--- a/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
@@ -112,10 +112,9 @@
auto Channels = createPairedQueueChannels();
- auto ReportError =
- [](Error Err) {
- logAllUnhandledErrors(std::move(Err), llvm::errs(), "");
- };
+ auto ReportError = [](Error Err) {
+ logAllUnhandledErrors(std::move(Err), llvm::errs());
+ };
// Copy the bytes out of the test object: the copy will be used to verify
// that the original is correctly transmitted over RPC to the mock layer.
@@ -225,10 +224,9 @@
auto Channels = createPairedQueueChannels();
- auto ReportError =
- [](Error Err) {
- logAllUnhandledErrors(std::move(Err), llvm::errs(), "");
- };
+ auto ReportError = [](Error Err) {
+ logAllUnhandledErrors(std::move(Err), llvm::errs());
+ };
RPCEndpoint ClientEP(*Channels.first, true);
RemoteObjectClientLayer<RPCEndpoint> Client(ClientEP, ReportError);
@@ -489,10 +487,9 @@
auto Channels = createPairedQueueChannels();
- auto ReportError =
- [](Error Err) {
- logAllUnhandledErrors(std::move(Err), llvm::errs(), "");
- };
+ auto ReportError = [](Error Err) {
+ logAllUnhandledErrors(std::move(Err), llvm::errs());
+ };
RPCEndpoint ClientEP(*Channels.first, true);
RemoteObjectClientLayer<RPCEndpoint> Client(ClientEP, ReportError);
diff --git a/llvm/unittests/Support/ErrorTest.cpp b/llvm/unittests/Support/ErrorTest.cpp
index ed1e2bb..eee2fe2 100644
--- a/llvm/unittests/Support/ErrorTest.cpp
+++ b/llvm/unittests/Support/ErrorTest.cpp
@@ -434,9 +434,8 @@
TEST(Error, StringError) {
std::string Msg;
raw_string_ostream S(Msg);
- logAllUnhandledErrors(make_error<StringError>("foo" + Twine(42),
- inconvertibleErrorCode()),
- S, "");
+ logAllUnhandledErrors(
+ make_error<StringError>("foo" + Twine(42), inconvertibleErrorCode()), S);
EXPECT_EQ(S.str(), "foo42\n") << "Unexpected StringError log result";
auto EC =
@@ -451,13 +450,13 @@
std::string Msg;
raw_string_ostream S(Msg);
logAllUnhandledErrors(createStringError(EC, "foo%s%d0x%" PRIx8, Bar, 1, 0xff),
- S, "");
+ S);
EXPECT_EQ(S.str(), "foobar10xff\n")
<< "Unexpected createStringError() log result";
S.flush();
Msg.clear();
- logAllUnhandledErrors(createStringError(EC, Bar), S, "");
+ logAllUnhandledErrors(createStringError(EC, Bar), S);
EXPECT_EQ(S.str(), "bar\n")
<< "Unexpected createStringError() (overloaded) log result";