commit 460675eba4ba56742139365caefbfde04071fe18
author George Karpenkov <ekarpenkov@apple.com> Tue Mar 13 17:27:01 2018 +0000
committer George Karpenkov <ekarpenkov@apple.com> Tue Mar 13 17:27:01 2018 +0000
tree 4fe202ed9c95b245e97d99a1c350e5ca3670ba2b
parent b52297508ef8c6801c194b90407479e093a00ed5

[analyzer] Fix the matcher for GCDAntipattern to look for "signal" call in all parameters

rdar://38405904

llvm-svn: 327426

clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp

diff --git a/clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
index 51a3fc1..bb1bd85 100644
--- a/clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
@@ -121,11 +121,11 @@
             hasCanonicalType(blockPointerType())
             ));
 
-  auto ArgCallsSignalM = hasArgument(0, hasDescendant(callExpr(
+  auto ArgCallsSignalM = hasAnyArgument(stmt(hasDescendant(callExpr(
           allOf(
               callsName("dispatch_semaphore_signal"),
               equalsBoundArgDecl(0, SemaphoreBinding)
-              ))));
+              )))));
 
   auto HasBlockAndCallsSignalM = allOf(HasBlockArgumentM, ArgCallsSignalM);