Access control for overloaded call operators. Not for surrogates yet,
mostly because we're going to want a better diagnostic for conversions.
Also this API needs to go back to sanity.
llvm-svn: 94730
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 5506eeb..55259fc 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -6231,6 +6231,8 @@
= cast<CXXConversionDecl>(
Best->Conversions[0].UserDefined.ConversionFunction);
+ // FIXME: access control
+
// We selected one of the surrogate functions that converts the
// object parameter to a function pointer. Perform the conversion
// on the object argument, then let ActOnCallExpr finish the job.
@@ -6244,6 +6246,9 @@
CommaLocs, RParenLoc).release();
}
+ if (getLangOptions().AccessControl)
+ CheckAccess(R, Best->Function, Best->getAccess());
+
// We found an overloaded operator(). Build a CXXOperatorCallExpr
// that calls this method, using Object for the implicit object
// parameter and passing along the remaining arguments.
diff --git a/clang/test/CXX/class.access/p4.cpp b/clang/test/CXX/class.access/p4.cpp
index 3f4397a..0df1791 100644
--- a/clang/test/CXX/class.access/p4.cpp
+++ b/clang/test/CXX/class.access/p4.cpp
@@ -38,12 +38,15 @@
public:
void operator+(Public&);
void operator[](Public&);
+ void operator()(Public&);
protected:
void operator+(Protected&); // expected-note {{declared protected here}}
void operator[](Protected&); // expected-note {{declared protected here}}
+ void operator()(Protected&); // expected-note {{declared protected here}}
private:
void operator+(Private&); // expected-note {{declared private here}}
void operator[](Private&); // expected-note {{declared private here}}
+ void operator()(Private&); // expected-note {{declared private here}}
void operator-(); // expected-note {{declared private here}}
};
void operator+(const A &, Public&);
@@ -58,6 +61,9 @@
a[pub];
a[prot]; // expected-error {{access to protected member}}
a[priv]; // expected-error {{access to private member}}
+ a(pub);
+ a(prot); // expected-error {{access to protected member}}
+ a(priv); // expected-error {{access to private member}}
-a; // expected-error {{access to private member}}
const A &ca = a;