commit 4a89501f820d6472e680f8187e3fe30a6559f140
author Greg Clayton <gclayton@apple.com> Thu Mar 14 22:52:17 2013 +0000
committer Greg Clayton <gclayton@apple.com> Thu Mar 14 22:52:17 2013 +0000
tree 59e7087b9575861f98dfdbe8bc97256ed2d404b8
parent 5cdc1937cc5f72bb99c043cd84dca6057cad4f78

<rdar://problem/12537646>

lldb remembers not-found source file, setting target.source-map doesn't make it re-check for it. Now this is fixed. Each time the source path remappings get updated, the modification ID in the PathMappingList gets bumped and then we know the re-check for sources.

llvm-svn: 177125

lldb/source/Core/SourceManager.cpp

diff --git a/lldb/source/Core/SourceManager.cpp b/lldb/source/Core/SourceManager.cpp
index 4d3e9f3..4267da3 100644
--- a/lldb/source/Core/SourceManager.cpp
+++ b/lldb/source/Core/SourceManager.cpp
@@ -67,8 +67,19 @@
 SourceManager::FileSP
 SourceManager::GetFile (const FileSpec &file_spec)
 {
+    bool same_as_previous = m_last_file_sp && m_last_file_sp->FileSpecMatches (file_spec);
+
     FileSP file_sp;
-    file_sp = m_debugger->GetSourceFileCache().FindSourceFile (file_spec);
+    if (same_as_previous)
+        file_sp = m_last_file_sp;
+    else
+        file_sp = m_debugger->GetSourceFileCache().FindSourceFile (file_spec);
+    
+    // It the target source path map has been updated, get this file again so we
+    // can successfully remap the source file
+    if (file_sp && file_sp->GetSourceMapModificationID() != m_target->GetSourcePathMap().GetModificationID())
+        file_sp.reset();
+
     // If file_sp is no good or it points to a non-existent file, reset it.
     if (!file_sp || !file_sp->GetFileSpec().Exists())
     {
@@ -159,10 +170,7 @@
     const SymbolContextList *bp_locs
 )
 {
-    bool same_as_previous = m_last_file_sp && m_last_file_sp->FileSpecMatches (file_spec);
-
-    if (!same_as_previous)
-        m_last_file_sp = GetFile (file_spec);
+    FileSP file_sp (GetFile (file_spec));
 
     uint32_t start_line;
     uint32_t count = context_before + context_after + 1;
@@ -171,12 +179,12 @@
     else
         start_line = 1;
     
-    if (line == 0)
+    if (m_last_file_sp.get() != file_sp.get())
     {
-        if (!same_as_previous)
+        if (line == 0)
             m_last_line = 0;
+        m_last_file_sp = file_sp;
     }
-
     return DisplaySourceLinesWithLineNumbersUsingLastFile (start_line, count, line, current_line_cstr, s, bp_locs);
 }
 
@@ -317,6 +325,7 @@
     m_file_spec_orig (file_spec),
     m_file_spec(file_spec),
     m_mod_time (file_spec.GetModificationTime()),
+    m_source_map_mod_id (0),
     m_data_sp(),
     m_offsets()
 {
@@ -324,6 +333,8 @@
     {
         if (target)
         {
+            m_source_map_mod_id = target->GetSourcePathMap().GetModificationID();
+
             if (!file_spec.GetDirectory() && file_spec.GetFilename())
             {
                 // If this is just a file name, lets see if we can find it in the target: