Sema: Fix explicit address space cast involving void pointers
Explicit cast of a void pointer to a pointer type in different address space is
incorrectly classified as bitcast, which causes invalid bitcast in codegen.
The patch fixes that by checking the address space of the source and destination
type and set the correct cast kind.
Differential Revision: https://reviews.llvm.org/D50003
llvm-svn: 338805
diff --git a/clang/lib/Sema/SemaCast.cpp b/clang/lib/Sema/SemaCast.cpp
index 57aac80..8599fe0 100644
--- a/clang/lib/Sema/SemaCast.cpp
+++ b/clang/lib/Sema/SemaCast.cpp
@@ -1044,6 +1044,17 @@
}
}
+static bool IsAddressSpaceConversion(QualType SrcType, QualType DestType) {
+ auto *SrcPtrType = SrcType->getAs<PointerType>();
+ if (!SrcPtrType)
+ return false;
+ auto *DestPtrType = DestType->getAs<PointerType>();
+ if (!DestPtrType)
+ return false;
+ return SrcPtrType->getPointeeType().getAddressSpace() !=
+ DestPtrType->getPointeeType().getAddressSpace();
+}
+
/// TryStaticCast - Check if a static cast can be performed, and do so if
/// possible. If @p CStyle, ignore access restrictions on hierarchy casting
/// and casting away constness.
@@ -1185,7 +1196,9 @@
return TC_Failed;
}
}
- Kind = CK_BitCast;
+ Kind = IsAddressSpaceConversion(SrcType, DestType)
+ ? CK_AddressSpaceConversion
+ : CK_BitCast;
return TC_Success;
}
@@ -1964,12 +1977,6 @@
return Result.isUsable();
}
-static bool IsAddressSpaceConversion(QualType SrcType, QualType DestType) {
- return SrcType->isPointerType() && DestType->isPointerType() &&
- SrcType->getAs<PointerType>()->getPointeeType().getAddressSpace() !=
- DestType->getAs<PointerType>()->getPointeeType().getAddressSpace();
-}
-
static TryCastResult TryReinterpretCast(Sema &Self, ExprResult &SrcExpr,
QualType DestType, bool CStyle,
SourceRange OpRange,