aha, DAE does have to think about PHI nodes. Many thanks to "Dr Evil" (aka Duncan)
for pointing this out :)
llvm-svn: 67212
diff --git a/llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp b/llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp
index ab8df69..666db7e 100644
--- a/llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp
+++ b/llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp
@@ -803,9 +803,9 @@
" must have been a struct!");
Instruction *InsertPt = Call;
if (InvokeInst *II = dyn_cast<InvokeInst>(Call)) {
- InsertPt = II->getNormalDest()->begin();
- assert(!isa<PHINode>(InsertPt) &&
- "Can't have a use of the invoke value if the edge is critical");
+ BasicBlock::iterator IP = II->getNormalDest()->begin();
+ while (isa<PHINode>(IP)) ++IP;
+ InsertPt = IP;
}
// We used to return a struct. Instead of doing smart stuff with all the
diff --git a/llvm/test/Transforms/DeadArgElim/2009-03-17-MRE-Invoke.ll b/llvm/test/Transforms/DeadArgElim/2009-03-17-MRE-Invoke.ll
index 6ccaa9f..f5f2ce1 100644
--- a/llvm/test/Transforms/DeadArgElim/2009-03-17-MRE-Invoke.ll
+++ b/llvm/test/Transforms/DeadArgElim/2009-03-17-MRE-Invoke.ll
@@ -13,3 +13,14 @@
T2:
unreachable
}
+
+define i32 @bar2() {
+entry:
+ %x = invoke {i32,i32} @foo() to label %T unwind label %T2
+T:
+ %PN = phi i32 [0, %entry]
+ %y = extractvalue {i32,i32} %x, 1
+ ret i32 %y
+T2:
+ unreachable
+}
\ No newline at end of file