For PR797:
Final commit for this bug. This removes the last EH holdouts in LLVM
and turns off exception support by using the -fno-exceptions option. This
leads to the following reduction in library and executable sizes:
DEBUG BUILD RELEASE BUILD
before after delta before after delta
lib 162,328K 157,616K 4,712 17,864K 16,416K 1,448K
bin 571,444K 557,156K 14,288 63,296K 56,996K 6,300K
Debug Improvement: 19,000K (2.59%)
Release Improvement: 7,748K (9.55%)
llvm-svn: 29882
diff --git a/llvm/lib/Bytecode/Reader/Reader.h b/llvm/lib/Bytecode/Reader/Reader.h
index 37dd1d7..711dc89 100644
--- a/llvm/lib/Bytecode/Reader/Reader.h
+++ b/llvm/lib/Bytecode/Reader/Reader.h
@@ -147,26 +147,21 @@
);
/// @brief Parse all function bodies
- void ParseAllFunctionBodies();
+ bool ParseAllFunctionBodies(std::string* ErrMsg);
/// @brief Parse the next function of specific type
- void ParseFunction(Function* Func) ;
+ bool ParseFunction(Function* Func, std::string* ErrMsg) ;
/// This method is abstract in the parent ModuleProvider class. Its
/// implementation is identical to the ParseFunction method.
/// @see ParseFunction
/// @brief Make a specific function materialize.
- virtual bool materializeFunction(Function *F, std::string *ErrInfo = 0) {
+ virtual bool materializeFunction(Function *F, std::string *ErrMsg = 0) {
LazyFunctionMap::iterator Fi = LazyFunctionLoadMap.find(F);
- if (Fi == LazyFunctionLoadMap.end()) return false;
- try {
- ParseFunction(F);
- } catch (std::string &ErrStr) {
- if (ErrInfo) *ErrInfo = ErrStr;
+ if (Fi == LazyFunctionLoadMap.end())
+ return false;
+ if (ParseFunction(F,ErrMsg))
return true;
- } catch (...) {
- return true;
- }
return false;
}
@@ -174,15 +169,9 @@
/// implementation is identical to ParseAllFunctionBodies.
/// @see ParseAllFunctionBodies
/// @brief Make the whole module materialize
- virtual Module* materializeModule(std::string *ErrInfo = 0) {
- try {
- ParseAllFunctionBodies();
- } catch (std::string &ErrStr) {
- if (ErrInfo) *ErrInfo = ErrStr;
+ virtual Module* materializeModule(std::string *ErrMsg = 0) {
+ if (ParseAllFunctionBodies(ErrMsg))
return 0;
- } catch (...) {
- return 0;
- }
return TheModule;
}