commit 52884b7be8b5c94111f6a9cd4397b4fd446fe320
author Adrian Prantl <aprantl@apple.com> Mon Mar 20 21:34:19 2017 +0000
committer Adrian Prantl <aprantl@apple.com> Mon Mar 20 21:34:19 2017 +0000
tree df3381ef6e7ec5f6dd34746ecb1b2269abc8efd4
parent 74fa24ff279c51bc432cefbb26dbc753a16c1b51

Make implementation details in DwarfExpression protected. (NFC)

llvm-svn: 298308

llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h

diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h b/llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
index 9c5925e..fde2be6 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
@@ -102,13 +102,6 @@
   /// Add masking operations to stencil out a subregister.
   void maskSubRegister();
 
-public:
-  DwarfExpression(unsigned DwarfVersion) : DwarfVersion(DwarfVersion) {}
-  virtual ~DwarfExpression() {};
-
-  /// This needs to be called last to commit any pending changes.
-  void finalize();
-
   /// Output a dwarf operand and an optional assembler comment.
   virtual void emitOp(uint8_t Op, const char *Comment = nullptr) = 0;
   /// Emit a raw signed value.
@@ -147,6 +140,13 @@
   /// expression.  See PR21176 for more details.
   void addStackValue();
 
+public:
+  DwarfExpression(unsigned DwarfVersion) : DwarfVersion(DwarfVersion) {}
+  virtual ~DwarfExpression() {};
+
+  /// This needs to be called last to commit any pending changes.
+  void finalize();
+
   /// Emit an indirect dwarf register operation for the given machine register.
   /// \return false if no DWARF register exists for MachineReg.
   bool addMachineRegIndirect(const TargetRegisterInfo &TRI, unsigned MachineReg,
@@ -206,15 +206,14 @@
 class DebugLocDwarfExpression : public DwarfExpression {
   ByteStreamer &BS;
 
-public:
-  DebugLocDwarfExpression(unsigned DwarfVersion, ByteStreamer &BS)
-      : DwarfExpression(DwarfVersion), BS(BS) {}
-
   void emitOp(uint8_t Op, const char *Comment = nullptr) override;
   void emitSigned(int64_t Value) override;
   void emitUnsigned(uint64_t Value) override;
   bool isFrameRegister(const TargetRegisterInfo &TRI,
                        unsigned MachineReg) override;
+public:
+  DebugLocDwarfExpression(unsigned DwarfVersion, ByteStreamer &BS)
+      : DwarfExpression(DwarfVersion), BS(BS) {}
 };
 
 /// DwarfExpression implementation for singular DW_AT_location.
@@ -223,13 +222,13 @@
   DwarfUnit &DU;
   DIELoc ¨
 
-public:
-  DIEDwarfExpression(const AsmPrinter &AP, DwarfUnit &DU, DIELoc &DIE);
   void emitOp(uint8_t Op, const char *Comment = nullptr) override;
   void emitSigned(int64_t Value) override;
   void emitUnsigned(uint64_t Value) override;
   bool isFrameRegister(const TargetRegisterInfo &TRI,
                        unsigned MachineReg) override;
+public:
+  DIEDwarfExpression(const AsmPrinter &AP, DwarfUnit &DU, DIELoc &DIE);
   DIELoc *finalize() {
     DwarfExpression::finalize();
     return ¨