commit 573050e703308c624e48c7f36f19dc2d83d7170f
author Sam McCall <sam.mccall@gmail.com> Thu Mar 09 10:47:44 2017 +0000
committer Sam McCall <sam.mccall@gmail.com> Thu Mar 09 10:47:44 2017 +0000
tree 117d50c89d6e50bda3d7fdd100a747702017e037
parent 76630d43f6081c657ac5be2406061d43334045dd

[include-fixer] Remove line number from Symbol identity

Summary:
Remove line number from Symbol identity.

For our purposes (include-fixer and clangd autocomplete), function overloads
within the same header should mostly be treated as a single combined symbol.

We may want to track individual occurrences (line number, full type info)
and aggregate this during mapreduce, but that's not done here.

Reviewers: hokein, bkramer

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D30685

llvm-svn: 297371

clang-tools-extra/unittests/include-fixer/IncludeFixerTest.cpp

diff --git a/clang-tools-extra/unittests/include-fixer/IncludeFixerTest.cpp b/clang-tools-extra/unittests/include-fixer/IncludeFixerTest.cpp
index 029590ae..8454669 100644
--- a/clang-tools-extra/unittests/include-fixer/IncludeFixerTest.cpp
+++ b/clang-tools-extra/unittests/include-fixer/IncludeFixerTest.cpp
@@ -54,43 +54,43 @@
     StringRef Code,
     const std::vector<std::string> &ExtraArgs = std::vector<std::string>()) {
   std::vector<SymbolAndSignals> Symbols = {
-      {SymbolInfo("string", SymbolInfo::SymbolKind::Class, "<string>", 1,
+      {SymbolInfo("string", SymbolInfo::SymbolKind::Class, "<string>",
                   {{SymbolInfo::ContextType::Namespace, "std"}}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("sting", SymbolInfo::SymbolKind::Class, "\"sting\"", 1,
+      {SymbolInfo("sting", SymbolInfo::SymbolKind::Class, "\"sting\"",
                   {{SymbolInfo::ContextType::Namespace, "std"}}),
        SymbolInfo::Signals{}},
       {SymbolInfo("foo", SymbolInfo::SymbolKind::Class,
-                  "\"dir/otherdir/qux.h\"", 1,
+                  "\"dir/otherdir/qux.h\"",
                   {{SymbolInfo::ContextType::Namespace, "b"},
                    {SymbolInfo::ContextType::Namespace, "a"}}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("bar", SymbolInfo::SymbolKind::Class, "\"bar.h\"", 1,
+      {SymbolInfo("bar", SymbolInfo::SymbolKind::Class, "\"bar.h\"",
                   {{SymbolInfo::ContextType::Namespace, "b"},
                    {SymbolInfo::ContextType::Namespace, "a"}}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("bar", SymbolInfo::SymbolKind::Class, "\"bar2.h\"", 1,
+      {SymbolInfo("bar", SymbolInfo::SymbolKind::Class, "\"bar2.h\"",
                   {{SymbolInfo::ContextType::Namespace, "c"},
                    {SymbolInfo::ContextType::Namespace, "a"}}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("Green", SymbolInfo::SymbolKind::Class, "\"color.h\"", 1,
+      {SymbolInfo("Green", SymbolInfo::SymbolKind::Class, "\"color.h\"",
                   {{SymbolInfo::ContextType::EnumDecl, "Color"},
                    {SymbolInfo::ContextType::Namespace, "b"},
                    {SymbolInfo::ContextType::Namespace, "a"}}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("Vector", SymbolInfo::SymbolKind::Class, "\"Vector.h\"", 1,
+      {SymbolInfo("Vector", SymbolInfo::SymbolKind::Class, "\"Vector.h\"",
                   {{SymbolInfo::ContextType::Namespace, "__a"},
                    {SymbolInfo::ContextType::Namespace, "a"}}),
        SymbolInfo::Signals{/*Seen=*/2, 0}},
-      {SymbolInfo("Vector", SymbolInfo::SymbolKind::Class, "\"Vector.h\"", 2,
+      {SymbolInfo("Vector", SymbolInfo::SymbolKind::Class, "\"Vector.h\"",
                   {{SymbolInfo::ContextType::Namespace, "a"}}),
        SymbolInfo::Signals{/*Seen=*/2, 0}},
-      {SymbolInfo("StrCat", SymbolInfo::SymbolKind::Class, "\"strcat.h\"", 1,
+      {SymbolInfo("StrCat", SymbolInfo::SymbolKind::Class, "\"strcat.h\"",
                   {{SymbolInfo::ContextType::Namespace, "str"}}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("str", SymbolInfo::SymbolKind::Class, "\"str.h\"", 1, {}),
+      {SymbolInfo("str", SymbolInfo::SymbolKind::Class, "\"str.h\"", {}),
        SymbolInfo::Signals{}},
-      {SymbolInfo("foo2", SymbolInfo::SymbolKind::Class, "\"foo2.h\"", 1, {}),
+      {SymbolInfo("foo2", SymbolInfo::SymbolKind::Class, "\"foo2.h\"", {}),
        SymbolInfo::Signals{}},
   };
   auto SymbolIndexMgr = llvm::make_unique<SymbolIndexManager>();