commit 5a7e0f835747a084be476c39e6cf322e3ae51409
author Benjamin Kramer <benny.kra@googlemail.com> Wed Feb 22 12:59:47 2017 +0000
committer Benjamin Kramer <benny.kra@googlemail.com> Wed Feb 22 12:59:47 2017 +0000
tree cea7c84076e36d6ce4ae5cec975f6194828ad10b
parent 2e0031b37162804d6a3b6a01d2e425027f094103

[GlobalISel] Fix compiler warnings and make assert assert something.

llvm-svn: 295827

llvm/lib/Target/X86/X86InstructionSelector.cpp

diff --git a/llvm/lib/Target/X86/X86InstructionSelector.cpp b/llvm/lib/Target/X86/X86InstructionSelector.cpp
index 9b21ce4..cc9fae5 100644
--- a/llvm/lib/Target/X86/X86InstructionSelector.cpp
+++ b/llvm/lib/Target/X86/X86InstructionSelector.cpp
@@ -37,10 +37,9 @@
 
 #include "X86GenGlobalISel.inc"
 
-X86InstructionSelector::X86InstructionSelector(const X86TargetMachine &TM,
-                                               const X86Subtarget &STI,
+X86InstructionSelector::X86InstructionSelector(const X86Subtarget &STI,
                                                const X86RegisterBankInfo &RBI)
-    : InstructionSelector(), TM(TM), STI(STI), TII(*STI.getInstrInfo()),
+    : InstructionSelector(), TII(*STI.getInstrInfo()),
       TRI(*STI.getRegisterInfo()), RBI(RBI) {}
 
 // FIXME: This should be target-independent, inferred from the types declared
@@ -70,6 +69,7 @@
 
   const RegisterBank &RegBank = *RBI.getRegBank(DstReg, MRI, TRI);
   const unsigned DstSize = MRI.getType(DstReg).getSizeInBits();
+  (void)DstSize;
   unsigned SrcReg = I.getOperand(1).getReg();
   const unsigned SrcSize = RBI.getSizeInBits(SrcReg, MRI, TRI);
   (void)SrcSize;
@@ -124,10 +124,8 @@
     return true;
   }
 
-  if (I.getNumOperands() != I.getNumExplicitOperands()) {
-    assert("Generic instruction has unexpected implicit operands\n");
-    return false;
-  }
+  assert(I.getNumOperands() == I.getNumExplicitOperands() &&
+         "Generic instruction has unexpected implicit operands\n");
 
   return selectImpl(I);
 }

llvm/lib/Target/X86/X86InstructionSelector.h

diff --git a/llvm/lib/Target/X86/X86InstructionSelector.h b/llvm/lib/Target/X86/X86InstructionSelector.h
index 0a8ea3d..774fce1 100644
--- a/llvm/lib/Target/X86/X86InstructionSelector.h
+++ b/llvm/lib/Target/X86/X86InstructionSelector.h
@@ -25,7 +25,7 @@
 
 class X86InstructionSelector : public InstructionSelector {
 public:
-  X86InstructionSelector(const X86TargetMachine &TM, const X86Subtarget &STI,
+  X86InstructionSelector(const X86Subtarget &STI,
                          const X86RegisterBankInfo &RBI);
 
   bool select(MachineInstr &I) const override;
@@ -35,8 +35,6 @@
   /// the patterns that don't require complex C++.
   bool selectImpl(MachineInstr &I) const;
 
-  const X86TargetMachine &TM;
-  const X86Subtarget &STI;
   const X86InstrInfo &TII;
   const X86RegisterInfo &TRI;
   const X86RegisterBankInfo &RBI;

llvm/lib/Target/X86/X86TargetMachine.cpp

diff --git a/llvm/lib/Target/X86/X86TargetMachine.cpp b/llvm/lib/Target/X86/X86TargetMachine.cpp
index 3f61cd8..d2a3b26 100644
--- a/llvm/lib/Target/X86/X86TargetMachine.cpp
+++ b/llvm/lib/Target/X86/X86TargetMachine.cpp
@@ -284,7 +284,7 @@
 
     auto *RBI = new X86RegisterBankInfo(*I->getRegisterInfo());
     GISel->RegBankInfo.reset(RBI);
-    GISel->InstSelector.reset(new X86InstructionSelector(*this, *I, *RBI));
+    GISel->InstSelector.reset(new X86InstructionSelector(*I, *RBI));
 
 #endif
     I->setGISelAccessor(*GISel);