llvm-readobj: address review comments for ARM EHABI printing

Rename bytecode to opcodes to make it more clear.  Change an impossible case to
llvm_unreachable instead.  Avoid allocation of a buffer by modifying the
PrintOpcodes iteration.

llvm-svn: 198848
diff --git a/llvm/test/tools/llvm-readobj/ARM/unwind.s b/llvm/test/tools/llvm-readobj/ARM/unwind.s
index 7d23a05..7606824 100644
--- a/llvm/test/tools/llvm-readobj/ARM/unwind.s
+++ b/llvm/test/tools/llvm-readobj/ARM/unwind.s
@@ -91,10 +91,10 @@
 @ CHECK:         FunctionName: __personality
 @ CHECK:         Model: Compact (Inline)
 @ CHECK:         PersonalityIndex: 0
-@ CHECK:         ByteCode [
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
+@ CHECK:         Opcodes [
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
 @ CHECK:         ]
 @ CHECK:       }
 @ CHECK:     ]
@@ -107,10 +107,10 @@
 @ CHECK:         FunctionName: personality0
 @ CHECK:         Model: Compact (Inline)
 @ CHECK:         PersonalityIndex: 0
-@ CHECK:         ByteCode [
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
+@ CHECK:         Opcodes [
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
 @ CHECK:         ]
 @ CHECK:       }
 @ CHECK:     ]
@@ -125,13 +125,13 @@
 @ CHECK:         TableEntryOffset: 0x0
 @ CHECK:         Model: Compact
 @ CHECK:         PersonalityIndex: 1
-@ CHECK:         ByteCode [
-@ CHECK:           Instruction: 0xB1
-@ CHECK:           Instruction: 0xF
-@ CHECK:           Instruction: 0xA7
-@ CHECK:           Instruction: 0x3F
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
+@ CHECK:         Opcodes [
+@ CHECK:           Opcode: 0xB1
+@ CHECK:           Opcode: 0xF
+@ CHECK:           Opcode: 0xA7
+@ CHECK:           Opcode: 0x3F
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
 @ CHECK:         ]
 @ CHECK:       }
 @ CHECK:     ]
@@ -157,10 +157,10 @@
 @ CHECK:         FunctionName: opcodes
 @ CHECK:         Model: Compact (Inline)
 @ CHECK:         PersonalityIndex: 0
-@ CHECK:         ByteCode [
-@ CHECK:           Instruction: 0xC9
-@ CHECK:           Instruction: 0x84
-@ CHECK:           Instruction: 0xB0
+@ CHECK:         Opcodes [
+@ CHECK:           Opcode: 0xC9
+@ CHECK:           Opcode: 0x84
+@ CHECK:           Opcode: 0xB0
 @ CHECK:         ]
 @ CHECK:       }
 @ CHECK:     ]
@@ -173,10 +173,10 @@
 @ CHECK:         FunctionName: function0
 @ CHECK:         Model: Compact (Inline)
 @ CHECK:         PersonalityIndex: 0
-@ CHECK:         ByteCode [
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
+@ CHECK:         Opcodes [
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
 @ CHECK:         ]
 @ CHECK:       }
 @ CHECK:       Entry {
@@ -191,10 +191,10 @@
 @ CHECK:         FunctionName: function2
 @ CHECK:         Model: Compact (Inline)
 @ CHECK:         PersonalityIndex: 0
-@ CHECK:         ByteCode [
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
-@ CHECK:           Instruction: 0xB0
+@ CHECK:         Opcodes [
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
+@ CHECK:           Opcode: 0xB0
 @ CHECK:         ]
 @ CHECK:       }
 @ CHECK:     ]