commit 5ffd2c3cfca82ecc7ab00b8e1b034a118ca5a27b
author Andrea Di Biagio <Andrea_DiBiagio@sn.scee.net> Mon Mar 26 14:25:52 2018 +0000
committer Andrea Di Biagio <Andrea_DiBiagio@sn.scee.net> Mon Mar 26 14:25:52 2018 +0000
tree 7b051e6b4ae65e930f5e77adbe002fd7272e9f1f
parent 2455fef497a09cf358daf43ea910eb5a23542980

[llvm-mca] Fix how views are added to the InstructionTables.

This should fix the stack-use-after-scope reported by the asan buildbots after
revision 328493.

llvm-svn: 328499

llvm/tools/llvm-mca/InstructionTables.cpp

diff --git a/llvm/tools/llvm-mca/InstructionTables.cpp b/llvm/tools/llvm-mca/InstructionTables.cpp
index 044b516..18691ad 100644
--- a/llvm/tools/llvm-mca/InstructionTables.cpp
+++ b/llvm/tools/llvm-mca/InstructionTables.cpp
@@ -69,12 +69,17 @@
       }
     }
 
-    // Now send a fake instruction issued event to all the listeners.
+    // Now send a fake instruction issued event to all the views.
     HWInstructionIssuedEvent Event(IR.first, UsedResources);
-    for (HWEventListener *Listener : Listeners)
+    for (std::unique_ptr<View> &Listener : Views)
       Listener->onInstructionEvent(Event);
     S.updateNext();
   }
 }
 
+void InstructionTables::printReport(llvm::raw_ostream &OS) const {
+  for (const std::unique_ptr<View> &V : Views)
+    V->printView(OS);
+}
+
 } // namespace mca

llvm/tools/llvm-mca/InstructionTables.h

diff --git a/llvm/tools/llvm-mca/InstructionTables.h b/llvm/tools/llvm-mca/InstructionTables.h
index 97dd9b8..200083d 100644
--- a/llvm/tools/llvm-mca/InstructionTables.h
+++ b/llvm/tools/llvm-mca/InstructionTables.h
@@ -17,9 +17,10 @@
 #ifndef LLVM_TOOLS_LLVM_MCA_INSTRUCTIONTABLES_H
 #define LLVM_TOOLS_LLVM_MCA_INSTRUCTIONTABLES_H
 
-#include "HWEventListener.h"
+#include "View.h"
 #include "InstrBuilder.h"
 #include "SourceMgr.h"
+#include "llvm/ADT/SmallVector.h"
 #include "llvm/MC/MCSchedule.h"
 
 namespace mca {
@@ -28,19 +29,20 @@
   const llvm::MCSchedModel &SM;
   InstrBuilder &IB;
   SourceMgr &S;
-  std::set<HWEventListener *> Listeners;
+  llvm::SmallVector<std::unique_ptr<View>, 8> Views;
 
 public:
   InstructionTables(const llvm::MCSchedModel &Model, InstrBuilder &Builder,
                     SourceMgr &Source)
       : SM(Model), IB(Builder), S(Source) {}
 
-  void addEventListener(HWEventListener *Listener) {
-    if (Listener)
-      Listeners.insert(Listener);
+  void addView(std::unique_ptr<View> V) {
+    Views.emplace_back(std::move(V));
   }
 
   void run();
+  
+  void printReport(llvm::raw_ostream &OS) const;
 };
 } // namespace mca
 

llvm/tools/llvm-mca/llvm-mca.cpp

diff --git a/llvm/tools/llvm-mca/llvm-mca.cpp b/llvm/tools/llvm-mca/llvm-mca.cpp
index cae4c27..49d5047 100644
--- a/llvm/tools/llvm-mca/llvm-mca.cpp
+++ b/llvm/tools/llvm-mca/llvm-mca.cpp
@@ -273,8 +273,8 @@
 
   std::unique_ptr<buffer_ostream> BOS;
 
-  std::unique_ptr<mca::SourceMgr> S =
-      llvm::make_unique<mca::SourceMgr>(PrintInstructionTables ? 1 : Iterations);
+  std::unique_ptr<mca::SourceMgr> S = llvm::make_unique<mca::SourceMgr>(
+      PrintInstructionTables ? 1 : Iterations);
   MCStreamerWrapper Str(Ctx, S->getSequence());
 
   std::unique_ptr<MCInstrInfo> MCII(TheTarget->createMCInstrInfo());
@@ -343,14 +343,13 @@
     mca::InstructionTables IT(STI->getSchedModel(), *IB, *S);
 
     if (PrintInstructionInfoView) {
-      mca::InstructionInfoView IIV(*STI, *MCII, *S, *IP);
-      IT.addEventListener(&IIV);
+      IT.addView(
+          llvm::make_unique<mca::InstructionInfoView>(*STI, *MCII, *S, *IP));
     }
 
-    mca::ResourcePressureView RPV(*STI, *IP, *S);
-    IT.addEventListener(&RPV);
+    IT.addView(llvm::make_unique<mca::ResourcePressureView>(*STI, *IP, *S));
     IT.run();
-    RPV.printView(TOF->os());
+    IT.printReport(TOF->os());
     TOF->keep();
     return 0;
   }