commit 6390d16fd19398b51d4e6f4552d3e755104a1629
author Rafael Espindola <rafael.espindola@gmail.com> Thu Oct 08 20:43:19 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Thu Oct 08 20:43:19 2015 +0000
tree 32786c51103c8f154dacf24f99f456125644b584
parent 38a2a28ff724cdc2f0a385847b2d733239226a4c

Don't silently ignore an error.

Found by inspection.

llvm-svn: 249744

lld/ELF/Writer.cpp

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index 6293505..9079f41 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -322,9 +322,11 @@
     if (!Config->DiscardAll) {
       Elf_Sym_Range Syms = File.getLocalSymbols();
       for (const Elf_Sym &Sym : Syms) {
-        ErrorOr<StringRef> SymName = Sym.getName(File.getStringTable());
-        if (SymName && shouldKeepInSymtab<ELFT>(*SymName, Sym))
-          Out<ELFT>::SymTab->addSymbol(*SymName, true);
+        ErrorOr<StringRef> SymNameOrErr = Sym.getName(File.getStringTable());
+        error(SymNameOrErr);
+        StringRef SymName = *SymNameOrErr;
+        if (shouldKeepInSymtab<ELFT>(SymName, Sym))
+          Out<ELFT>::SymTab->addSymbol(SymName, true);
       }
     }
     for (InputSection<ELFT> *C : File.getSections()) {