commit 63e5fb76ecfed3434252868d8cf07d676f979f2f
author Jonas Devlieghere <jonas@devlieghere.com> Wed Jul 24 17:56:10 2019 +0000
committer Jonas Devlieghere <jonas@devlieghere.com> Wed Jul 24 17:56:10 2019 +0000
tree 349d6bd303f53aa57b988dee284c7f264404a8fc
parent 2bf871be4c35d70db080dde789cf9bb334c04057

[Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

This patch replaces explicit calls to log::Printf with the new LLDB_LOGF
macro. The macro is similar to LLDB_LOG but supports printf-style format
strings, instead of formatv-style format strings.

So instead of writing:

  if (log)
    log->Printf("%s\n", str);

You'd write:

  LLDB_LOG(log, "%s\n", str);

This change was done mechanically with the command below. I replaced the
spurious if-checks with vim, since I know how to do multi-line
replacements with it.

  find . -type f -name '*.cpp' -exec \
  sed -i '' -E 's/log->Printf\(/LLDB_LOGF\(log, /g' "{}" +

Differential revision: https://reviews.llvm.org/D65128

llvm-svn: 366936

lldb/source/Expression/ExpressionVariable.cpp

diff --git a/lldb/source/Expression/ExpressionVariable.cpp b/lldb/source/Expression/ExpressionVariable.cpp
index 97305dc..ed8da0a 100644
--- a/lldb/source/Expression/ExpressionVariable.cpp
+++ b/lldb/source/Expression/ExpressionVariable.cpp
@@ -45,8 +45,7 @@
 
   m_execution_units.insert(execution_unit_sp);
 
-  if (log)
-    log->Printf("Registering JITted Functions:\n");
+  LLDB_LOGF(log, "Registering JITted Functions:\n");
 
   for (const IRExecutionUnit::JittedFunction &jitted_function :
        execution_unit_sp->GetJittedFunctions()) {
@@ -55,15 +54,13 @@
         jitted_function.m_remote_addr != LLDB_INVALID_ADDRESS) {
       m_symbol_map[jitted_function.m_name.GetCString()] =
           jitted_function.m_remote_addr;
-      if (log)
-        log->Printf("  Function: %s at 0x%" PRIx64 ".",
-                    jitted_function.m_name.GetCString(),
-                    jitted_function.m_remote_addr);
+      LLDB_LOGF(log, "  Function: %s at 0x%" PRIx64 ".",
+                jitted_function.m_name.GetCString(),
+                jitted_function.m_remote_addr);
     }
   }
 
-  if (log)
-    log->Printf("Registering JIIted Symbols:\n");
+  LLDB_LOGF(log, "Registering JIIted Symbols:\n");
 
   for (const IRExecutionUnit::JittedGlobalVariable &global_var :
        execution_unit_sp->GetJittedGlobalVariables()) {
@@ -74,9 +71,8 @@
       Mangled mangler(global_var.m_name);
       mangler.GetDemangledName(lldb::eLanguageTypeUnknown);
       m_symbol_map[global_var.m_name.GetCString()] = global_var.m_remote_addr;
-      if (log)
-        log->Printf("  Symbol: %s at 0x%" PRIx64 ".",
-                    global_var.m_name.GetCString(), global_var.m_remote_addr);
+      LLDB_LOGF(log, "  Symbol: %s at 0x%" PRIx64 ".",
+                global_var.m_name.GetCString(), global_var.m_remote_addr);
     }
   }
 }