IR: Store MDNodes in a separate LeakDetector container
This gives us better leak detection messages, like `Value` has.
This also has the side effect of papering over a problem where
`MachineInstr`s are added as garbage to the leak detector and then
deleted without being removed. If `MDNode::getTemporary()` allocates an
`MDNodeFwdDecl` in the same spot, the leak detector asserts. By
separating `MDNode`s into their own container we lose that assertion.
Since `MachineInstr` is required to have a trivial destructor, its usage
of `LeakDetector` at all is pretty suspect. I'll be sending a patch
soon to strip that out.
llvm-svn: 224060
diff --git a/llvm/lib/IR/LeakDetector.cpp b/llvm/lib/IR/LeakDetector.cpp
index 6f71627..be07a48 100644
--- a/llvm/lib/IR/LeakDetector.cpp
+++ b/llvm/lib/IR/LeakDetector.cpp
@@ -14,6 +14,7 @@
#include "llvm/IR/LeakDetector.h"
#include "LLVMContextImpl.h"
#include "llvm/ADT/SmallPtrSet.h"
+#include "llvm/IR/Metadata.h"
#include "llvm/IR/Value.h"
#include "llvm/Support/Compiler.h"
#include "llvm/Support/ManagedStatic.h"
@@ -39,6 +40,11 @@
pImpl->LLVMObjects.addGarbage(Object);
}
+void LeakDetector::addGarbageObjectImpl(const MDNode *Object) {
+ LLVMContextImpl *pImpl = Object->getContext().pImpl;
+ pImpl->LLVMMDObjects.addGarbage(Object);
+}
+
void LeakDetector::removeGarbageObjectImpl(void *Object) {
sys::SmartScopedLock<true> Lock(*ObjectsLock);
Objects->removeGarbage(Object);
@@ -49,6 +55,11 @@
pImpl->LLVMObjects.removeGarbage(Object);
}
+void LeakDetector::removeGarbageObjectImpl(const MDNode *Object) {
+ LLVMContextImpl *pImpl = Object->getContext().pImpl;
+ pImpl->LLVMMDObjects.removeGarbage(Object);
+}
+
void LeakDetector::checkForGarbageImpl(LLVMContext &Context,
const std::string &Message) {
LLVMContextImpl *pImpl = Context.pImpl;
@@ -56,10 +67,12 @@
Objects->setName("GENERIC");
pImpl->LLVMObjects.setName("LLVM");
+ pImpl->LLVMMDObjects.setName("LLVM-MD");
// use non-short-circuit version so that both checks are performed
if (Objects->hasGarbage(Message) |
- pImpl->LLVMObjects.hasGarbage(Message))
+ pImpl->LLVMObjects.hasGarbage(Message) |
+ pImpl->LLVMMDObjects.hasGarbage(Message))
errs() << "\nThis is probably because you removed an object, but didn't "
<< "delete it. Please check your code for memory leaks.\n";