[tooling] RefactoringCallbacks code cleanup
This diff
1. adds missing "explicit" for single argument constructors
2. adds missing std::move in ReplaceNodeWithTemplate constructor
Test plan: make check-all
Differential revision: https://reviews.llvm.org/D33061
llvm-svn: 302855
diff --git a/clang/lib/Tooling/RefactoringCallbacks.cpp b/clang/lib/Tooling/RefactoringCallbacks.cpp
index ad0a10d..9fd333c 100644
--- a/clang/lib/Tooling/RefactoringCallbacks.cpp
+++ b/clang/lib/Tooling/RefactoringCallbacks.cpp
@@ -38,7 +38,7 @@
class RefactoringASTConsumer : public ASTConsumer {
public:
- RefactoringASTConsumer(ASTMatchRefactorer &Refactoring)
+ explicit RefactoringASTConsumer(ASTMatchRefactorer &Refactoring)
: Refactoring(Refactoring) {}
void HandleTranslationUnit(ASTContext &Context) override {
@@ -153,8 +153,8 @@
}
ReplaceNodeWithTemplate::ReplaceNodeWithTemplate(
- llvm::StringRef FromId, std::vector<TemplateElement> &&Template)
- : FromId(FromId), Template(Template) {}
+ llvm::StringRef FromId, std::vector<TemplateElement> Template)
+ : FromId(FromId), Template(std::move(Template)) {}
llvm::Expected<std::unique_ptr<ReplaceNodeWithTemplate>>
ReplaceNodeWithTemplate::create(StringRef FromId, StringRef ToTemplate) {