commit 6f05a743f7c5101876b27d30d20f653ca21de6b4
author Simon Pilgrim <llvm-dev@redking.me.uk> Fri Sep 22 13:32:26 2017 +0000
committer Simon Pilgrim <llvm-dev@redking.me.uk> Fri Sep 22 13:32:26 2017 +0000
tree 82c622f18f201f8ad6af41d34d6a43d243159cc3
parent 34498ba052ee83a931a894509bab2369a411809a

[TableGen] Return StringRef from ValueTypeByHwMode::getMVTName

Avoid unnecessary std::string creations during TypeSetByHwMode::writeToStream.

Found during investigations into PR28222

Differential Revision: https://reviews.llvm.org/D38174

llvm-svn: 313983

llvm/utils/TableGen/InfoByHwMode.cpp

diff --git a/llvm/utils/TableGen/InfoByHwMode.cpp b/llvm/utils/TableGen/InfoByHwMode.cpp
index 882a6a7..aee0dd6 100644
--- a/llvm/utils/TableGen/InfoByHwMode.cpp
+++ b/llvm/utils/TableGen/InfoByHwMode.cpp
@@ -70,10 +70,9 @@
   return Map.insert(std::make_pair(Mode, Type)).first->second;
 }
 
-std::string ValueTypeByHwMode::getMVTName(MVT T) {
-  std::string N = llvm::getEnumName(T.SimpleTy);
-  if (N.substr(0,5) == "MVT::")
-    N = N.substr(5);
+StringRef ValueTypeByHwMode::getMVTName(MVT T) {
+  StringRef N = llvm::getEnumName(T.SimpleTy);
+  N.consume_front("MVT::");
   return N;
 }
 
@@ -91,7 +90,7 @@
   for (unsigned i = 0, e = Pairs.size(); i != e; ++i) {
     const PairType *P = Pairs[i];
     str << '(' << getModeName(P->first)
-        << ':' << getMVTName(P->second) << ')';
+        << ':' << getMVTName(P->second).str() << ')';
     if (i != e-1)
       str << ',';
   }

llvm/utils/TableGen/InfoByHwMode.h

diff --git a/llvm/utils/TableGen/InfoByHwMode.h b/llvm/utils/TableGen/InfoByHwMode.h
index 71149e8..57640fc 100644
--- a/llvm/utils/TableGen/InfoByHwMode.h
+++ b/llvm/utils/TableGen/InfoByHwMode.h
@@ -129,7 +129,7 @@
   MVT getType(unsigned Mode) const { return get(Mode); }
   MVT &getOrCreateTypeForMode(unsigned Mode, MVT Type);
 
-  static std::string getMVTName(MVT T);
+  static StringRef getMVTName(MVT T);
   std::string getAsString() const;
   void dump() const;
 };