commit 729727ebc7e9e5b27e73b1ae0fdaa4bb7c312098
author River Riddle <riverriddle@google.com> Fri Sep 20 19:47:05 2019 -0700
committer A. Unique TensorFlower <gardener@tensorflow.org> Fri Sep 20 19:47:32 2019 -0700
tree 1528e2a155d4d0794f7e7a220d980484249cb831
parent 91125d33ed9a46495a50338ce206ddf5c461a763

NFC: Pass OperationState by reference instead of by pointer.

MLIR follows the LLVM convention of passing by reference instead of by pointer.

PiperOrigin-RevId: 270396945

mlir/lib/Dialect/LoopOps/LoopOps.cpp

diff --git a/mlir/lib/Dialect/LoopOps/LoopOps.cpp b/mlir/lib/Dialect/LoopOps/LoopOps.cpp
index 74da12f..ddc2636 100644
--- a/mlir/lib/Dialect/LoopOps/LoopOps.cpp
+++ b/mlir/lib/Dialect/LoopOps/LoopOps.cpp
@@ -49,11 +49,11 @@
 // ForOp
 //===----------------------------------------------------------------------===//
 
-void ForOp::build(Builder *builder, OperationState *result, Value *lb,
+void ForOp::build(Builder *builder, OperationState &result, Value *lb,
                   Value *ub, Value *step) {
-  result->addOperands({lb, ub, step});
-  Region *bodyRegion = result->addRegion();
-  ForOp::ensureTerminator(*bodyRegion, *builder, result->location);
+  result.addOperands({lb, ub, step});
+  Region *bodyRegion = result.addRegion();
+  ForOp::ensureTerminator(*bodyRegion, *builder, result.location);
   bodyRegion->front().addArgument(builder->getIndexType());
 }
 
@@ -82,7 +82,7 @@
   p->printOptionalAttrDict(op.getAttrs());
 }
 
-static ParseResult parseForOp(OpAsmParser &parser, OperationState *result) {
+static ParseResult parseForOp(OpAsmParser &parser, OperationState &result) {
   auto &builder = parser.getBuilder();
   OpAsmParser::OperandType inductionVariable, lb, ub, step;
   // Parse the induction variable followed by '='.
@@ -92,22 +92,22 @@
   // Parse loop bounds.
   Type indexType = builder.getIndexType();
   if (parser.parseOperand(lb) ||
-      parser.resolveOperand(lb, indexType, result->operands) ||
+      parser.resolveOperand(lb, indexType, result.operands) ||
       parser.parseKeyword("to") || parser.parseOperand(ub) ||
-      parser.resolveOperand(ub, indexType, result->operands) ||
+      parser.resolveOperand(ub, indexType, result.operands) ||
       parser.parseKeyword("step") || parser.parseOperand(step) ||
-      parser.resolveOperand(step, indexType, result->operands))
+      parser.resolveOperand(step, indexType, result.operands))
     return failure();
 
   // Parse the body region.
-  Region *body = result->addRegion();
+  Region *body = result.addRegion();
   if (parser.parseRegion(*body, inductionVariable, indexType))
     return failure();
 
-  ForOp::ensureTerminator(*body, builder, result->location);
+  ForOp::ensureTerminator(*body, builder, result.location);
 
   // Parse the optional attribute list.
-  if (parser.parseOptionalAttributeDict(result->attributes))
+  if (parser.parseOptionalAttributeDict(result.attributes))
     return failure();
 
   return success();
@@ -126,14 +126,14 @@
 // IfOp
 //===----------------------------------------------------------------------===//
 
-void IfOp::build(Builder *builder, OperationState *result, Value *cond,
+void IfOp::build(Builder *builder, OperationState &result, Value *cond,
                  bool withElseRegion) {
-  result->addOperands(cond);
-  Region *thenRegion = result->addRegion();
-  Region *elseRegion = result->addRegion();
-  IfOp::ensureTerminator(*thenRegion, *builder, result->location);
+  result.addOperands(cond);
+  Region *thenRegion = result.addRegion();
+  Region *elseRegion = result.addRegion();
+  IfOp::ensureTerminator(*thenRegion, *builder, result.location);
   if (withElseRegion)
-    IfOp::ensureTerminator(*elseRegion, *builder, result->location);
+    IfOp::ensureTerminator(*elseRegion, *builder, result.location);
 }
 
 static LogicalResult verify(IfOp op) {
@@ -150,33 +150,33 @@
   return success();
 }
 
-static ParseResult parseIfOp(OpAsmParser &parser, OperationState *result) {
+static ParseResult parseIfOp(OpAsmParser &parser, OperationState &result) {
   // Create the regions for 'then'.
-  result->regions.reserve(2);
-  Region *thenRegion = result->addRegion();
-  Region *elseRegion = result->addRegion();
+  result.regions.reserve(2);
+  Region *thenRegion = result.addRegion();
+  Region *elseRegion = result.addRegion();
 
   auto &builder = parser.getBuilder();
   OpAsmParser::OperandType cond;
   Type i1Type = builder.getIntegerType(1);
   if (parser.parseOperand(cond) ||
-      parser.resolveOperand(cond, i1Type, result->operands))
+      parser.resolveOperand(cond, i1Type, result.operands))
     return failure();
 
   // Parse the 'then' region.
   if (parser.parseRegion(*thenRegion, {}, {}))
     return failure();
-  IfOp::ensureTerminator(*thenRegion, parser.getBuilder(), result->location);
+  IfOp::ensureTerminator(*thenRegion, parser.getBuilder(), result.location);
 
   // If we find an 'else' keyword then parse the 'else' region.
   if (!parser.parseOptionalKeyword("else")) {
     if (parser.parseRegion(*elseRegion, {}, {}))
       return failure();
-    IfOp::ensureTerminator(*elseRegion, parser.getBuilder(), result->location);
+    IfOp::ensureTerminator(*elseRegion, parser.getBuilder(), result.location);
   }
 
   // Parse the optional attribute list.
-  if (parser.parseOptionalAttributeDict(result->attributes))
+  if (parser.parseOptionalAttributeDict(result.attributes))
     return failure();
 
   return success();