commit 73b0b2f55503e6b72e6525a115965a184e1a1dd7
author Zachary Turner <zturner@google.com> Thu Jun 16 18:09:04 2016 +0000
committer Zachary Turner <zturner@google.com> Thu Jun 16 18:09:04 2016 +0000
tree 8496dfc19ffd91b805c68a4f0c32d193bab454aa
parent 1f6372c429ce6b85a572c213d53f0ed8d293ff38

Revert "[pdb] Change type visitor pattern to be dynamic."

This reverts commit fb0dd311e1ad945827b8ffd5354f4810e2be1579.

This breaks some llvm-readobj tests.

llvm-svn: 272927

llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp

diff --git a/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp b/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
index 2ae63e0..4df324f 100644
--- a/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
+++ b/llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
@@ -328,10 +328,8 @@
     for (auto &Type : Tpi->types(&HadError)) {
       DictScope DD(P, "");
 
-      if (DumpRecords) {
-        if (auto EC = TD.dump(Type))
-          return EC;
-      }
+      if (DumpRecords)
+        TD.dump(Type);
 
       if (DumpRecordBytes)
         P.printBinaryBlock("Bytes", Type.Data);
@@ -349,10 +347,8 @@
     TD.setPrinter(nullptr);
 
     bool HadError = false;
-    for (auto &Type : Tpi->types(&HadError)) {
-      if (auto EC = TD.dump(Type))
-        return EC;
-    }
+    for (auto &Type : Tpi->types(&HadError))
+      TD.dump(Type);
 
     TD.setPrinter(OldP);
     dumpTpiHash(P, *Tpi);