[clang-tidy] Remove static StringSet in favor of binary search.
The number of strings is so small that performance doesn't matter and adding
the thread safe static initialization and destruction overhead is just not
worth it. No functional change intended.
llvm-svn: 235192
diff --git a/clang-tools-extra/clang-tidy/readability/ShrinkToFitCheck.cpp b/clang-tools-extra/clang-tidy/readability/ShrinkToFitCheck.cpp
index 400ce31..9c159ff 100644
--- a/clang-tools-extra/clang-tidy/readability/ShrinkToFitCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/ShrinkToFitCheck.cpp
@@ -12,22 +12,18 @@
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/Lex/Lexer.h"
#include "llvm/ADT/StringRef.h"
-#include "llvm/ADT/StringSet.h"
using namespace clang::ast_matchers;
-namespace {
-bool isShrinkableContainer(llvm::StringRef ClassName) {
- static const llvm::StringSet<> Shrinkables = [] {
- llvm::StringSet<> RetVal;
- RetVal.insert("std::deque");
- RetVal.insert("std::basic_string");
- RetVal.insert("std::vector");
- return RetVal;
- }();
- return Shrinkables.find(ClassName) != Shrinkables.end();
+static bool isShrinkableContainer(llvm::StringRef ClassName) {
+ static const char *Shrinkables[] = {
+ "std::basic_string",
+ "std::deque",
+ "std::vector"
+ };
+ return std::binary_search(std::begin(Shrinkables), std::end(Shrinkables),
+ ClassName);
}
-} // namespace
namespace clang {
namespace ast_matchers {