Don't define our own global 'endl' variable. While technically it had
internal linkage and so wasn't a patent bug, it doesn't make any sense
here. We can avoid even calling operator<< by just embedding the newline
in the string literals that were already being streamed out. It also
gives the impression of some line-ending agnosticisms which is not
present, and that flushing happens when it doesn't.
If we want to use std::endl, we could do that, but honestly it doesn't
seem remotely worth it. Using '\n' directly is much more clear when
working with raw_ostream.
It also happens to fix builds with old crufty GCC STL implementations
that include std::endl into the global namespace (or headers written to
be compatible with such atrocities).
llvm-svn: 179003
diff --git a/llvm/tools/obj2yaml/obj2yaml.cpp b/llvm/tools/obj2yaml/obj2yaml.cpp
index bdc461a..68701de 100644
--- a/llvm/tools/obj2yaml/obj2yaml.cpp
+++ b/llvm/tools/obj2yaml/obj2yaml.cpp
@@ -16,8 +16,6 @@
#include "llvm/Support/PrettyStackTrace.h"
#include "llvm/Support/Signals.h"
-const char endl = '\n';
-
namespace yaml { // generic yaml-writing specific routines
unsigned char printable(unsigned char Ch) {
@@ -37,7 +35,7 @@
Out << "\" # |";
for (iter_t iter = arr.begin(); iter != end; ++iter)
Out << printable(*iter);
- Out << "|" << endl;
+ Out << "|\n";
return Out;
}
@@ -75,11 +73,11 @@
// TODO: If this is an archive, then burst it and dump each entry
if (error_code ec = MemoryBuffer::getFileOrSTDIN(InputFilename, buf))
llvm::errs() << "Error: '" << ec.message() << "' opening file '"
- << InputFilename << "'" << endl;
+ << InputFilename << "'\n";
else {
ec = coff2yaml(llvm::outs(), buf.take());
if (ec)
- llvm::errs() << "Error: " << ec.message() << " dumping COFF file" << endl;
+ llvm::errs() << "Error: " << ec.message() << " dumping COFF file\n";
}
return 0;