commit 7aa95a9fca87a90f861b2a70619a6f19d8dd86b9
author Reid Kleckner <rnk@google.com> Fri Jul 01 00:37:25 2016 +0000
committer Reid Kleckner <rnk@google.com> Fri Jul 01 00:37:25 2016 +0000
tree 617be9ea155be632339eac4e1e2b37af02bea2da
parent d7e8898bdd83abf38faaee110805b36ff259c5f6

[PDB] Indicate which type record failed hash validation

llvm-svn: 274308

llvm/lib/DebugInfo/PDB/Raw/TpiStream.cpp

diff --git a/llvm/lib/DebugInfo/PDB/Raw/TpiStream.cpp b/llvm/lib/DebugInfo/PDB/Raw/TpiStream.cpp
index feb6f2b..016c51b 100644
--- a/llvm/lib/DebugInfo/PDB/Raw/TpiStream.cpp
+++ b/llvm/lib/DebugInfo/PDB/Raw/TpiStream.cpp
@@ -118,7 +118,7 @@
   template <typename T> Error verify(T &Rec) {
     uint32_t Hash = getTpiHash(Rec, *RawRecord);
     if (Hash % NumHashBuckets != HashValues[Index])
-      return make_error<RawError>(raw_error_code::invalid_tpi_hash);
+      return errorInvalidHash();
     return Error::success();
   }
 
@@ -127,10 +127,16 @@
     support::endian::write32le(Buf, Rec.getUDT().getIndex());
     uint32_t Hash = hashStringV1(StringRef(Buf, 4));
     if (Hash % NumHashBuckets != HashValues[Index])
-      return make_error<RawError>(raw_error_code::invalid_tpi_hash);
+      return errorInvalidHash();
     return Error::success();
   }
 
+  Error errorInvalidHash() {
+    return make_error<RawError>(
+        raw_error_code::invalid_tpi_hash,
+        "Type index is 0x" + utohexstr(TypeIndex::FirstNonSimpleIndex + Index));
+  }
+
   FixedStreamArray<support::ulittle32_t> HashValues;
   const CVRecord<TypeLeafKind> *RawRecord;
   uint32_t NumHashBuckets;